Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: getrpcinfo docs #15754

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
5 participants
@benthecarman
Copy link
Contributor

commented Apr 5, 2019

Fixes #15731

Show resolved Hide resolved src/rpc/server.cpp Outdated

@benthecarman benthecarman force-pushed the benthecarman:rpc_get_info_doc branch from 54f7fdf to 2c85eb8 Apr 5, 2019

@promag
Copy link
Member

left a comment

The output should be something like

Result:
{
 "active_commands" (array) All active commands
   [                 
     {             (object) Information about an active command
       "method"    (string) The name of the RPC command
       "duration"  (numeric) The running time in microseconds
     },...
   ]
}

@benthecarman benthecarman force-pushed the benthecarman:rpc_get_info_doc branch from 2c85eb8 to f4b7a2f Apr 5, 2019

@promag

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

LGTM.

@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Apr 8, 2019

@MarcoFalke MarcoFalke modified the milestones: 0.18.0, 0.18.1 Apr 8, 2019

@promag promag referenced this pull request Apr 8, 2019

Closed

v0.18.0 testing #15555

RPCResults{},
RPCExamples{""},
RPCResult{
"{\n"

This comment has been minimized.

Copy link
@laanwj

laanwj Apr 10, 2019

Member

Maybe indent this line and the strings below it four to the right?

@laanwj

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

utACK f4b7a2f

@MarcoFalke MarcoFalke modified the milestones: 0.18.1, 0.18.0 Apr 10, 2019

@MarcoFalke MarcoFalke merged commit f4b7a2f into bitcoin:master Apr 10, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Apr 10, 2019

Merge #15754: rpc: getrpcinfo docs
f4b7a2f rpc: getrpcinfo docs (Ben Carman)

Pull request description:

  Fixes #15731

ACKs for commit f4b7a2:
  laanwj:
    utACK f4b7a2f

Tree-SHA512: 45dce83c4bfac2ddf85133a29aee332e9de8f73c15438ce899a2edbcd0d82d4f743753f6699c50cbc62d110fa8c6bc257722447e1090cdd23acbe00f26014ec8

benthecarman added a commit to benthecarman/bitcoin that referenced this pull request Apr 11, 2019

rpc: getrpcinfo docs
Github-Pull: bitcoin#15754
Rebased-From: f4b7a2f

laanwj added a commit that referenced this pull request Apr 15, 2019

Merge #15790: [0.18] backport #15754
60d4621 rpc: getrpcinfo docs (Ben Carman)

Pull request description:

  Backports #15754 to the 0.18 branch

  #15754 added the help message for `getrpcinfo`

ACKs for commit 60d462:
  promag:
    utACK 60d4621.
  fanquake:
    utACK 60d4621

Tree-SHA512: 3c0f0aded2dbd300b1cb5e3a3abb1d84852a165aa6ebb337833f06ba135730192a6e86b58323e4c5eb3a7636268125bea7be05925b5b316220bfa5ac1de4a5f4
@fanquake

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Bckported in #15790.

@benthecarman benthecarman deleted the benthecarman:rpc_get_info_doc branch Apr 16, 2019

HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this pull request Apr 19, 2019

rpc: getrpcinfo docs
Github-Pull: bitcoin#15754
Rebased-From: f4b7a2f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.