Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: Add shortcuts for tab tools #15756

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@promag
Copy link
Member

promag commented Apr 5, 2019

This makes accessing the RPC console very fast/easy. It also improves accessibility.

Screenshot 2019-04-05 at 16 22 02

@fanquake fanquake added the GUI label Apr 5, 2019

@Empact

This comment has been minimized.

Copy link
Member

Empact commented Apr 6, 2019

Concept ACK - letters could be more mnemonic and stable over time because they aren't tied to the order of the list.

@promag

This comment has been minimized.

Copy link
Member Author

promag commented Apr 7, 2019

@Empact could be, open for suggestions. Just used 1 to 4 because those are the tab indexes in the dialog.

@Empact

This comment has been minimized.

Copy link
Member

Empact commented Apr 8, 2019

Sure, I could go either way.

@jonasschnelli

This comment has been minimized.

Copy link
Member

jonasschnelli commented Apr 8, 2019

Concept ACK
No strong opinion about numbers versus something not tied to an order.

@jonasschnelli

This comment has been minimized.

Copy link
Member

jonasschnelli commented Apr 8, 2019

@Empact

This comment has been minimized.

Copy link
Member

Empact commented Apr 10, 2019

utACK 2e2b30b

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Apr 15, 2019

would it make sense to make these shortcuts application-global ? (see #15768 (comment)). I personally kind of expected pressing multiple in sequence e.g. Ctrl-1 Ctrl-2 to work.

@promag

This comment has been minimized.

Copy link
Member Author

promag commented Apr 15, 2019

@laanwj currently it does, at least on macos. Have you tested in other OS?

@promag

This comment has been minimized.

Copy link
Member Author

promag commented Apr 15, 2019

BTW, one could argue that these shortcuts are better fit for Overview, Send, Receive and Transactions tabs in the main window.

@luke-jr

This comment has been minimized.

Copy link
Member

luke-jr commented Apr 18, 2019

Alt-1..4 already work for the main window tabs.

I'm not sure using numbers for a different window makes sense.

@promag

This comment has been minimized.

Copy link
Member Author

promag commented Apr 18, 2019

@luke-jr I wasn't aware of that. On macos shortcuts are usually with CMD (Qt::CTRL).

So do you suggest using letters?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.