Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List new RPCs in psbt.md and descriptors.md #15757

Merged
merged 2 commits into from Apr 9, 2019

Conversation

Projects
None yet
6 participants
@sipa
Copy link
Member

commented Apr 5, 2019

The documentation in psbt.md and descriptors.md does not list new and updated RPCs (analyzepsbt, utxoupdatepsbt, joinpsbts, deriveaddresses, getdescriptorinfo, listunspent). Fix this.

It'd be good to have this in 0.18 (only documentation).

@fanquake fanquake added the Docs label Apr 5, 2019

@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Apr 5, 2019

@instagibbs

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

utACK ece60eb

@jonatack
Copy link
Contributor

left a comment

utACK ece60eb

Show resolved Hide resolved doc/descriptors.md Outdated

@sipa sipa force-pushed the sipa:201904_docupdate branch from ece60eb to 9b085f4 Apr 6, 2019

@fanquake

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

utACK 9b085f4

@laanwj laanwj merged commit 9b085f4 into bitcoin:master Apr 9, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Apr 9, 2019

Merge #15757: List new RPCs in psbt.md and descriptors.md
9b085f4 Mention new descriptor RPCs in descriptors.md (Pieter Wuille)
28d78de Mention new PSBT RPCs in psbt.md (Pieter Wuille)

Pull request description:

  The documentation in `psbt.md` and `descriptors.md` does not list new and updated RPCs (`analyzepsbt`, `utxoupdatepsbt`, `joinpsbts`, `deriveaddresses`, `getdescriptorinfo`, `listunspent`). Fix this.

  It'd be good to have this in 0.18 (only documentation).

ACKs for commit 9b085f:
  fanquake:
    utACK 9b085f4

Tree-SHA512: ee16907e8c15351a530f11fc0a585c50835a7bf5aec997ac0e897949d9b9e41a28ddebbeaba69753fee7d2de75e518091518185085fcd1f6ada94b7231097b2e

fanquake added a commit to fanquake/bitcoin that referenced this pull request Apr 9, 2019

Mention new PSBT RPCs in psbt.md
Github-Pull: bitcoin#15757
Rebased-From: 28d78de

fanquake added a commit to fanquake/bitcoin that referenced this pull request Apr 9, 2019

@fanquake fanquake removed the Needs backport label Apr 9, 2019

@fanquake

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Backported in #15775.

HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this pull request Apr 19, 2019

HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this pull request Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.