Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List new RPCs in psbt.md and descriptors.md #15757

Merged
merged 2 commits into from Apr 9, 2019
Merged

Conversation

@sipa
Copy link
Member

@sipa sipa commented Apr 5, 2019

The documentation in psbt.md and descriptors.md does not list new and updated RPCs (analyzepsbt, utxoupdatepsbt, joinpsbts, deriveaddresses, getdescriptorinfo, listunspent). Fix this.

It'd be good to have this in 0.18 (only documentation).

@fanquake fanquake added the Docs label Apr 5, 2019
@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Apr 5, 2019
@instagibbs
Copy link
Member

@instagibbs instagibbs commented Apr 5, 2019

utACK ece60eb

Copy link
Member

@jonatack jonatack left a comment

utACK ece60eb

doc/descriptors.md Outdated Show resolved Hide resolved
@sipa sipa force-pushed the 201904_docupdate branch from ece60eb to 9b085f4 Apr 6, 2019
@fanquake
Copy link
Member

@fanquake fanquake commented Apr 7, 2019

utACK 9b085f4

@laanwj laanwj merged commit 9b085f4 into bitcoin:master Apr 9, 2019
2 checks passed
laanwj added a commit that referenced this issue Apr 9, 2019
9b085f4 Mention new descriptor RPCs in descriptors.md (Pieter Wuille)
28d78de Mention new PSBT RPCs in psbt.md (Pieter Wuille)

Pull request description:

  The documentation in `psbt.md` and `descriptors.md` does not list new and updated RPCs (`analyzepsbt`, `utxoupdatepsbt`, `joinpsbts`, `deriveaddresses`, `getdescriptorinfo`, `listunspent`). Fix this.

  It'd be good to have this in 0.18 (only documentation).

ACKs for commit 9b085f:
  fanquake:
    utACK 9b085f4

Tree-SHA512: ee16907e8c15351a530f11fc0a585c50835a7bf5aec997ac0e897949d9b9e41a28ddebbeaba69753fee7d2de75e518091518185085fcd1f6ada94b7231097b2e
fanquake added a commit to fanquake/bitcoin that referenced this issue Apr 9, 2019
fanquake added a commit to fanquake/bitcoin that referenced this issue Apr 9, 2019
@fanquake
Copy link
Member

@fanquake fanquake commented Apr 9, 2019

Backported in #15775.

HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this issue Apr 19, 2019
HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this issue Apr 19, 2019
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Oct 5, 2020
Summary:
Backport of Core [[bitcoin/bitcoin#15757 | PR15757]] and [[bitcoin/bitcoin#16047 | PR16047]]

Depends on D7758

Test Plan:
Check rendering of markdown in a viewer.
Verify all commands added to the doc are listed in `bitcoin-cli help`

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7759
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 30, 2021
9b085f4 Mention new descriptor RPCs in descriptors.md (Pieter Wuille)
28d78de Mention new PSBT RPCs in psbt.md (Pieter Wuille)

Pull request description:

  The documentation in `psbt.md` and `descriptors.md` does not list new and updated RPCs (`analyzepsbt`, `utxoupdatepsbt`, `joinpsbts`, `deriveaddresses`, `getdescriptorinfo`, `listunspent`). Fix this.

  It'd be good to have this in 0.18 (only documentation).

ACKs for commit 9b085f:
  fanquake:
    utACK 9b085f4

Tree-SHA512: ee16907e8c15351a530f11fc0a585c50835a7bf5aec997ac0e897949d9b9e41a28ddebbeaba69753fee7d2de75e518091518185085fcd1f6ada94b7231097b2e
Munkybooty added a commit to Munkybooty/dash that referenced this issue Oct 7, 2021
9b085f4 Mention new descriptor RPCs in descriptors.md (Pieter Wuille)
28d78de Mention new PSBT RPCs in psbt.md (Pieter Wuille)

Pull request description:

  The documentation in `psbt.md` and `descriptors.md` does not list new and updated RPCs (`analyzepsbt`, `utxoupdatepsbt`, `joinpsbts`, `deriveaddresses`, `getdescriptorinfo`, `listunspent`). Fix this.

  It'd be good to have this in 0.18 (only documentation).

ACKs for commit 9b085f:
  fanquake:
    utACK 9b085f4

Tree-SHA512: ee16907e8c15351a530f11fc0a585c50835a7bf5aec997ac0e897949d9b9e41a28ddebbeaba69753fee7d2de75e518091518185085fcd1f6ada94b7231097b2e
Munkybooty added a commit to Munkybooty/dash that referenced this issue Oct 12, 2021
9b085f4 Mention new descriptor RPCs in descriptors.md (Pieter Wuille)
28d78de Mention new PSBT RPCs in psbt.md (Pieter Wuille)

Pull request description:

  The documentation in `psbt.md` and `descriptors.md` does not list new and updated RPCs (`analyzepsbt`, `utxoupdatepsbt`, `joinpsbts`, `deriveaddresses`, `getdescriptorinfo`, `listunspent`). Fix this.

  It'd be good to have this in 0.18 (only documentation).

ACKs for commit 9b085f:
  fanquake:
    utACK 9b085f4

Tree-SHA512: ee16907e8c15351a530f11fc0a585c50835a7bf5aec997ac0e897949d9b9e41a28ddebbeaba69753fee7d2de75e518091518185085fcd1f6ada94b7231097b2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants