Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: correct bitcoinconsensus_version in shared-libraries.md #15765

Merged
merged 1 commit into from Apr 9, 2019

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Apr 7, 2019

#define BITCOINCONSENSUS_API_VER 1

@fanquake fanquake added the Docs label Apr 7, 2019
@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Apr 7, 2019

ACK 8ae6d02

@Empact
Copy link
Member

@Empact Empact commented Apr 8, 2019

How about remove it entirely?

@luke-jr
Copy link
Member

@luke-jr luke-jr commented Apr 8, 2019

Nah, it's good to know what API version the file is documenting.

Recently wrote a FUSE filesystem, and found it annoying that they had API changes after the library on my system, but there was no way to tell which API each version of the tutorial(s) were written for.

@promag
Copy link
Member

@promag promag commented Apr 8, 2019

ACK 8ae6d02.

@laanwj
Copy link
Member

@laanwj laanwj commented Apr 9, 2019

Nah, it's good to know what API version the file is documenting.

👍

@laanwj laanwj merged commit 8ae6d02 into bitcoin:master Apr 9, 2019
2 checks passed
laanwj added a commit that referenced this issue Apr 9, 2019
…es.md

8ae6d02 doc: correct bitcoinconsensus_version in shared-libraries (fanquake)

Pull request description:

  https://github.com/bitcoin/bitcoin/blob/efbc86733a551f2e1f5c43cd6de4fc730c7cce65/src/script/bitcoinconsensus.h#L36

ACKs for commit 8ae6d0:
  practicalswift:
    ACK 8ae6d02
  promag:
    ACK 8ae6d02.

Tree-SHA512: 48ba90afe02beaa0fc9c3baf24ab7477e7e36947abcf424dab515aaaf5be35b9df3af5a01fc2653f0216a83d9bbff6f1d48bb86131fa71c552798a2e73ffbd82
fanquake added a commit to fanquake/bitcoin that referenced this issue Apr 9, 2019
@fanquake fanquake deleted the bitcoin_consensus_version branch Apr 15, 2019
HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this issue Apr 19, 2019
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Oct 5, 2020
Summary: Backport of Core [[bitcoin/bitcoin#15765 | PR15765]]

Test Plan: Verify that `BITCOINCONSENSUS_API_VER` is 1 in `bitcoinconsensus.h`

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7761
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 30, 2021
…libraries.md

8ae6d02 doc: correct bitcoinconsensus_version in shared-libraries (fanquake)

Pull request description:

  https://github.com/bitcoin/bitcoin/blob/efbc86733a551f2e1f5c43cd6de4fc730c7cce65/src/script/bitcoinconsensus.h#L36

ACKs for commit 8ae6d0:
  practicalswift:
    ACK 8ae6d02
  promag:
    ACK 8ae6d02.

Tree-SHA512: 48ba90afe02beaa0fc9c3baf24ab7477e7e36947abcf424dab515aaaf5be35b9df3af5a01fc2653f0216a83d9bbff6f1d48bb86131fa71c552798a2e73ffbd82
Munkybooty added a commit to Munkybooty/dash that referenced this issue Oct 7, 2021
…libraries.md

8ae6d02 doc: correct bitcoinconsensus_version in shared-libraries (fanquake)

Pull request description:

  https://github.com/bitcoin/bitcoin/blob/efbc86733a551f2e1f5c43cd6de4fc730c7cce65/src/script/bitcoinconsensus.h#L36

ACKs for commit 8ae6d0:
  practicalswift:
    ACK 8ae6d02
  promag:
    ACK 8ae6d02.

Tree-SHA512: 48ba90afe02beaa0fc9c3baf24ab7477e7e36947abcf424dab515aaaf5be35b9df3af5a01fc2653f0216a83d9bbff6f1d48bb86131fa71c552798a2e73ffbd82
Munkybooty added a commit to Munkybooty/dash that referenced this issue Oct 12, 2021
…libraries.md

8ae6d02 doc: correct bitcoinconsensus_version in shared-libraries (fanquake)

Pull request description:

  https://github.com/bitcoin/bitcoin/blob/efbc86733a551f2e1f5c43cd6de4fc730c7cce65/src/script/bitcoinconsensus.h#L36

ACKs for commit 8ae6d0:
  practicalswift:
    ACK 8ae6d02
  promag:
    ACK 8ae6d02.

Tree-SHA512: 48ba90afe02beaa0fc9c3baf24ab7477e7e36947abcf424dab515aaaf5be35b9df3af5a01fc2653f0216a83d9bbff6f1d48bb86131fa71c552798a2e73ffbd82
vijaydasmp added a commit to vijaydasmp/dash that referenced this issue Oct 18, 2021
…libraries.md

8ae6d02 doc: correct bitcoinconsensus_version in shared-libraries (fanquake)

Pull request description:

  https://github.com/bitcoin/bitcoin/blob/efbc86733a551f2e1f5c43cd6de4fc730c7cce65/src/script/bitcoinconsensus.h#L36

ACKs for commit 8ae6d0:
  practicalswift:
    ACK 8ae6d02
  promag:
    ACK 8ae6d02.

Tree-SHA512: 48ba90afe02beaa0fc9c3baf24ab7477e7e36947abcf424dab515aaaf5be35b9df3af5a01fc2653f0216a83d9bbff6f1d48bb86131fa71c552798a2e73ffbd82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants