Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: correct bitcoinconsensus_version in shared-libraries.md #15765

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
6 participants
@fanquake
Copy link
Member

commented Apr 7, 2019

#define BITCOINCONSENSUS_API_VER 1

@fanquake fanquake added the Docs label Apr 7, 2019

@practicalswift

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

ACK 8ae6d02

@Empact

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

How about remove it entirely?

@luke-jr

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

Nah, it's good to know what API version the file is documenting.

Recently wrote a FUSE filesystem, and found it annoying that they had API changes after the library on my system, but there was no way to tell which API each version of the tutorial(s) were written for.

@promag

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

ACK 8ae6d02.

@laanwj

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Nah, it's good to know what API version the file is documenting.

👍

@laanwj laanwj merged commit 8ae6d02 into bitcoin:master Apr 9, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Apr 9, 2019

Merge #15765: doc: correct bitcoinconsensus_version in shared-librari…
…es.md

8ae6d02 doc: correct bitcoinconsensus_version in shared-libraries (fanquake)

Pull request description:

  https://github.com/bitcoin/bitcoin/blob/efbc86733a551f2e1f5c43cd6de4fc730c7cce65/src/script/bitcoinconsensus.h#L36

ACKs for commit 8ae6d0:
  practicalswift:
    ACK 8ae6d02
  promag:
    ACK 8ae6d02.

Tree-SHA512: 48ba90afe02beaa0fc9c3baf24ab7477e7e36947abcf424dab515aaaf5be35b9df3af5a01fc2653f0216a83d9bbff6f1d48bb86131fa71c552798a2e73ffbd82

fanquake added a commit to fanquake/bitcoin that referenced this pull request Apr 9, 2019

@fanquake fanquake deleted the fanquake:bitcoin_consensus_version branch Apr 15, 2019

HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this pull request Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.