Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Clarify RPC versioning #15799

Merged
merged 1 commit into from Apr 15, 2019

Conversation

Projects
None yet
8 participants
@MarcoFalke
Copy link
Member

commented Apr 11, 2019

No description provided.

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #15778 ([wallet] Move maxtxfee from node to wallet by jnewbery)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@jnewbery

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

ACK fabd413

@fanquake fanquake added the Docs label Apr 11, 2019

@fanquake

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

utACK fabd413

## Versioning

The RPC interface might change from one major version of Bitcoin Core to the
next. This makes the PRC interface implicitly versioned on the major version.

This comment has been minimized.

Copy link
@instagibbs

instagibbs Apr 12, 2019

Member

PRC wow getting political eh?

@instagibbs

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

utACK except for the part defining interfaces for China

@practicalswift

This comment has been minimized.

Copy link
Member

commented Apr 13, 2019

utACK fabd413 modulo political content discovered by @instagibbs

@promag

This comment has been minimized.

Copy link
Member

commented Apr 14, 2019

utACK

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:1904-docRPC branch from fabd413 to fa74749 Apr 15, 2019

@MarcoFalke MarcoFalke referenced this pull request Apr 15, 2019

Merged

[0.18] doc backports #15818

@MarcoFalke MarcoFalke merged commit fa74749 into bitcoin:master Apr 15, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@MarcoFalke MarcoFalke deleted the MarcoFalke:1904-docRPC branch Apr 15, 2019

MarcoFalke added a commit that referenced this pull request Apr 15, 2019

Merge #15799: doc: Clarify RPC versioning
fa74749 doc: Clarify RPC versioning (MarcoFalke)

Pull request description:

ACKs for commit fa7474:

Tree-SHA512: 4d374cc9ae77a06423acc9c73fe29f706f4349c548b17cb2414f15f72e0fc8c6ef7783ce099e938db2ab949717a4ef29e1aebc6aa09a350853d7f875b192ccb5

fanquake added a commit to fanquake/bitcoin that referenced this pull request Apr 16, 2019

doc: Clarify RPC versioning
Github-Pull: bitcoin#15799
Rebased-From: fa74749
@fanquake

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

Backported in #15818.

HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this pull request Apr 19, 2019

uhliksk added a commit to fxtc-development/fxtc that referenced this pull request May 20, 2019

doc: Clarify RPC versioning
Github-Pull: bitcoin#15799
Rebased-From: fa74749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.