Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[0.18] Revert GetData randomization change (#14897) #15839
This is for 0.18, not master -- I propose we revert the getdata change for the 0.18 release, rather than try to continue patching it up. It seems like we've turned up several additional bugs that slipped through initial review (see #15776, #15834), and given the potential severe consequences of these bugs I think it'd make more sense for us to delay releasing this code until 0.19.
Since the bugfix PRs are getting review, I think we can leave #14897 in master, but we can separately discuss if it should be reverted in master as well if anyone thinks that would be more appropriate.
referenced this pull request
Apr 17, 2019
I think reverting for 0.18 is reasonable.
Regarding reverting in master: it seems like you're the only person working on that chunk of code, so keeping it there perhaps won't hurt for now? I'd propose just to spend more time looking for potential issues there.