Relay blocks as a "preview" before checking the transactions in them #1586

Closed
wants to merge 2 commits into from

3 participants

@luke-jr
Bitcoin member

DRAFT status, please help test! Trying to coordinate testing on IRC, possibly using NTP and https://gist.github.com/3094657

@jgarzik
Bitcoin member

@gmaxwell and I are definitely interested in this, at least. Will keep this pull request open.

A rebase would be nice, if you have time.

@luke-jr
Bitcoin member

Unfortunately, it seems p2p connections are handled synchronously, so everything this does to rush out the relaying is for naught. The only simple way I can see to refactor this to be asynchronous would be either to use coroutines (which Boost won't have until 2013) or one thread per command/connection. Either one is probably too late for 0.7, as would be an even larger refactor, I presume?

@BitcoinPullTester

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/4e54ea804ccdd2223e622497f0d46cceb27b9d22 for binaries and test log.

@BitcoinPullTester

Automatic sanity-testing: FAILED MERGE, see http://jenkins.bluematt.me/pull-tester/4e54ea804ccdd2223e622497f0d46cceb27b9d22 for test log.

This pull does not merge cleanly onto current master
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@jgarzik
Bitcoin member

Closing - timeout. Interesting proposal, needs more work and dev momentum.

@jgarzik jgarzik closed this Aug 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment