Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA: Add wallet_implicitsegwit to test the ability to transform keys between address types #15888

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@luke-jr
Copy link
Member

commented Apr 25, 2019

This makes sure the wallet recognises payments to keys via address types they weren't created with.

While we don't want this behaviour, it might make sense to explicitly test that it works until we remove it.

@fanquake fanquake added the Tests label Apr 25, 2019

@luke-jr luke-jr force-pushed the luke-jr:test_wallet_implicitsegwit branch from 52b02f0 to 6e22635 Apr 25, 2019

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #16016 ([tests] RPC bumpfee totalFee deprecation by jonatack)
  • #15996 (Deprecate totalfee argument in bumpfee by instagibbs)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.