Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: dummywallet: Add -ignorepartialspends to list of ignored wallet options #15913

Merged
merged 2 commits into from Apr 29, 2019

Conversation

Projects
None yet
8 participants
@luke-jr
Copy link
Member

commented Apr 28, 2019

When building w/o wallet support, we add all the wallet options as hidden options to avoid throwing errors/warnings that they're unknown.

-ignorepartialspends is missing from this list. This PR adds it.

(This seems like a good candidate for a linter? Or maybe we can autogenerate it?)

Also reformats the dummywallet options list across multiple lines to make conflicts less often.

@fanquake fanquake added the Wallet label Apr 28, 2019

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Apr 28, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #15876 ([rpc] signer bump fee by Sjors)
  • #14912 ([WIP] External signer support (e.g. hardware wallet) by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@meshcollider

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

utACK 765d589

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

utACK 765d589

Show signature
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

utACK 765d5890be46ed5f5557c1d2b3cb931e6b8eb3b0
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUhXNQv/bJNXsHQ/cB73ZsX3PmHL7vNjhGZkTWu0t5RRG6jKB6QxgWE4y2Mf3m9w
GFURtVz9pop6+Rsl+MgT2FwvXtvgnFp/2jthN3lXNU7u22BB8uVPAS7CUUXKqEH9
zo5Xp9Q/8GCh0z/GSHJyxVa0GT7DdYs9GfXWakKStbQ+PO42ZJI2eT8V+AMiFP2s
kiyJHX55I1xCqwwRNQn3Alrsq+cvsXWfSb9QutsinJLDCzeVa7K342CY+YKxVKU6
TqyDig/Ex3rdW0+1LqdPgKX8xugEEahfRAS9pI3g3YPgh7coJb2vCBRlRi5dpN9h
WBrs0ZxUlmcp8yncPqOilJCGP4mpRUTAtxEcbmfjgEE67qpl+4DflLTH8NQyaJT6
cj/eISi1tRUimPApgbkcfNn41JK+lR6oen1Xa1MXZnwWQXb3Au4cEiE2gyyC1cTX
UD2Q04K2qES1dm1Jxu8lIVWhQkOorNInBo6H0Siaphzcm5adzbW5fBRai4eQWRAe
oh7e2uMF
=QgEK
-----END PGP SIGNATURE-----

@luke-jr See MarcoFalke@fac174e for a linter fixup

@promag

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

utACK 765d589.

@practicalswift

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

utACK 765d589

Good idea with a linter guarding against this happening in the future.

@fanquake

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

utACK 765d589

@MarcoFalke MarcoFalke merged commit 765d589 into bitcoin:master Apr 29, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Apr 29, 2019

Merge #15913: Bugfix: dummywallet: Add -ignorepartialspends to list o…
…f ignored wallet options

765d589 Bugfix: dummywallet: Add -ignorepartialspends to list of ignored wallet options (Luke Dashjr)
0f09eb7 dummywallet: Reformat ignored wallet options list (Luke Dashjr)

Pull request description:

  When building w/o wallet support, we add all the wallet options as hidden options to avoid throwing errors/warnings that they're unknown.

  `-ignorepartialspends` is missing from this list. This PR adds it.

  (This seems like a good candidate for a linter? Or maybe we can autogenerate it?)

  Also reformats the dummywallet options list across multiple lines to make conflicts less often.

ACKs for commit 765d58:
  meshcollider:
    utACK 765d589
  MarcoFalke:
    utACK 765d589
  promag:
    utACK 765d589.
  practicalswift:
    utACK 765d589
  fanquake:
    utACK 765d589

Tree-SHA512: 37c8037148bdc1b7a8bde201eff51ee6a64c042c17eb8b6c68faef490d16575348c2f22ab81f48302b8ad80a5559222af23b721a8b5acc1d89c0757fb88796a6
@luke-jr

This comment has been minimized.

Copy link
Member Author

commented May 1, 2019

Probably should tag this for backport to 0.18.1

@fanquake fanquake added this to the 0.18.1 milestone May 1, 2019

@Sjors

This comment has been minimized.

Copy link
Member

commented May 12, 2019

Also reformats the dummywallet options list across multiple lines to make conflicts less often.

Thanks, that was indeed leading to frequent rebase needs for me in #14145.

Post merge utACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.