Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utils and libraries: fix static_assert for macro HAVE_THREAD_LOCAL #15970

Merged
merged 1 commit into from May 16, 2019

Conversation

@orientye
Copy link
Contributor

commented May 7, 2019

Utils and libraries: fix static_assert for macro HAVE_THREAD_LOCAL if define DEBUG_LOCKCONTENTION

fix static_assert for macro HAVE_THREAD_LOCAL while define DEBUG_LOCKCONTENTION
@orientye orientye changed the title fix static_assert for macro HAVE_THREAD_LOCAL Utils and libraries: fix static_assert for macro HAVE_THREAD_LOCAL May 7, 2019
@orientye

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

The clang compiler give static_assert err if define macro DEBUG_LOCKCONTENTION on mac osx.(HAVE_THREAD_LOCAL was defined in confiure.ac, and thread_local is supported by the os)

here is the src:
#ifdef DEBUG_LOCKCONTENTION
#if !defined(HAVE_THREAD_LOCAL)
static_assert(false, "thread_local is not supported");
#endif
because it lacks include <config/bitcoin-config.h> in sync.cpp for HAVE_THREAD_LOCAL macro.

This PR has fixed this bug.

@laanwj

This comment has been minimized.

Copy link
Member

commented May 16, 2019

utACK 41ab2a8

@laanwj laanwj merged commit 41ab2a8 into bitcoin:master May 16, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request May 16, 2019
…HREAD_LOCAL

41ab2a8 fix static_assert for macro HAVE_THREAD_LOCAL (orient)

Pull request description:

  Utils and libraries: fix static_assert for macro HAVE_THREAD_LOCAL if define DEBUG_LOCKCONTENTION

ACKs for commit 41ab2a:
  laanwj:
    utACK 41ab2a8

Tree-SHA512: 6c1d20375a70cbdef1140c544f443106d6bf6c34b1da2ddc66739f2b662a0d6b800288f48bf451a3d5937bac7e40b8ecda3a4effcc978d0093fc497410447ea7
sidhujag added a commit to syscoin/syscoin that referenced this pull request May 18, 2019
… HAVE_THREAD_LOCAL

41ab2a8 fix static_assert for macro HAVE_THREAD_LOCAL (orient)

Pull request description:

  Utils and libraries: fix static_assert for macro HAVE_THREAD_LOCAL if define DEBUG_LOCKCONTENTION

ACKs for commit 41ab2a:
  laanwj:
    utACK 41ab2a8

Tree-SHA512: 6c1d20375a70cbdef1140c544f443106d6bf6c34b1da2ddc66739f2b662a0d6b800288f48bf451a3d5937bac7e40b8ecda3a4effcc978d0093fc497410447ea7
@LitecoinZ LitecoinZ referenced this pull request May 31, 2019
44 of 244 tasks complete
LitecoinZ added a commit to litecoinz-core/wip that referenced this pull request May 31, 2019
… HAVE_THREAD_LOCAL

41ab2a8 fix static_assert for macro HAVE_THREAD_LOCAL (orient)

Pull request description:

  Utils and libraries: fix static_assert for macro HAVE_THREAD_LOCAL if define DEBUG_LOCKCONTENTION

ACKs for commit 41ab2a:
  laanwj:
    utACK 41ab2a8

Tree-SHA512: 6c1d20375a70cbdef1140c544f443106d6bf6c34b1da2ddc66739f2b662a0d6b800288f48bf451a3d5937bac7e40b8ecda3a4effcc978d0093fc497410447ea7
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Sep 3, 2019
fix static_assert for macro HAVE_THREAD_LOCAL while define DEBUG_LOCKCONTENTION

Github-Pull: bitcoin#15970
Rebased-From: 41ab2a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.