New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parameter "from" to listtransactions (range queries) #160

Merged
merged 2 commits into from May 9, 2011

Conversation

Projects
None yet
2 participants
@CAFxX
Contributor

CAFxX commented Apr 15, 2011

add parameter from to listtransactions this allows querying for ranges, i.e. transactions [from, from+count)

@gavinandresen

This comment has been minimized.

Show comment
Hide comment
@gavinandresen

gavinandresen Apr 15, 2011

Contributor

Please start a thread on the forums about this (if you haven't already): http://www.bitcoin.org/smf/index.php?board=6.0

Contributor

gavinandresen commented Apr 15, 2011

Please start a thread on the forums about this (if you haven't already): http://www.bitcoin.org/smf/index.php?board=6.0

@CAFxX

This comment has been minimized.

Show comment
Hide comment
Contributor

CAFxX commented Apr 15, 2011

@gavinandresen

This comment has been minimized.

Show comment
Hide comment
@gavinandresen

gavinandresen May 1, 2011

Contributor

Did you test calling this from command-line bitcoind? I don't see a call to ConvertTo down around line 2090 of rpc.cpp to convert the third param from a string to an integer.

Contributor

gavinandresen commented May 1, 2011

Did you test calling this from command-line bitcoind? I don't see a call to ConvertTo down around line 2090 of rpc.cpp to convert the third param from a string to an integer.

@CAFxX

This comment has been minimized.

Show comment
Hide comment
@CAFxX

CAFxX May 7, 2011

Contributor

whoops! nope, I didn't test the command-line. fixed.

Contributor

CAFxX commented May 7, 2011

whoops! nope, I didn't test the command-line. fixed.

gavinandresen added a commit that referenced this pull request May 9, 2011

Merge pull request #160 from CAFxX/listtransactions-from
add parameter "from" to listtransactions (range queries)

@gavinandresen gavinandresen merged commit 6244e44 into bitcoin:master May 9, 2011

@gavinandresen

This comment has been minimized.

Show comment
Hide comment
@gavinandresen

gavinandresen May 9, 2011

Contributor

In the future, please test your patches before submitting. This broke the build, and the feature was broken, too.

Contributor

gavinandresen commented May 9, 2011

In the future, please test your patches before submitting. This broke the build, and the feature was broken, too.

@CAFxX

This comment has been minimized.

Show comment
Hide comment
@CAFxX

CAFxX May 9, 2011

Contributor

Fixed and tested (linux-x64). You may want to pull because I also forgot to change the number of incoming parameters (see CAFxX@80d9115#L0R1085 )
Sorry about the breakage, I assumed a number of things that in the end turned out to be quite different.

Contributor

CAFxX commented May 9, 2011

Fixed and tested (linux-x64). You may want to pull because I also forgot to change the number of incoming parameters (see CAFxX@80d9115#L0R1085 )
Sorry about the breakage, I assumed a number of things that in the end turned out to be quite different.

dexX7 pushed a commit to dexX7/bitcoin that referenced this pull request Oct 13, 2014

sipa added a commit to sipa/bitcoin that referenced this pull request Jan 5, 2015

Squashed 'src/secp256k1/' changes from bccaf86..50cc6ab
50cc6ab Merge pull request bitcoin#178
941e221 Add tests for handling of the nonce function in signing.
10c81ff Merge pull request bitcoin#177
7688e34 Add magnitude limits to secp256k1_fe_verify to ensure that it's own tests function correctly.
4ee4f7a Merge pull request bitcoin#176
70ae0d2 Use secp256k1_fe_equal_var in secp256k1_fe_sqrt_var.
7767b4d Merge pull request bitcoin#175
9ab9335 Add a reference consistency test to ge_tests.
60571c6 Rework group tests
d26e26f Avoid constructing an invalid signature with probability 1:2^256.
b450c34 Merge pull request bitcoin#163
d57cae9 Merge pull request bitcoin#154
49ee0db Add _normalizes_to_zero_var variant
eed599d Add _fe_normalizes_to_zero method
d7174ed Weak normalization for secp256k1_fe_equal
0295f0a weak normalization
bbd5ba7 Use rfc6979 as default nonce generation function
b37fbc2 Implement SHA256 / HMAC-SHA256 / RFC6979.
c6e7f4e [API BREAK] Use a nonce-generation function instead of a nonce
cf0c48b Merge pull request bitcoin#169
603c33b Make signing fail if a too small buffer is passed.
6d16606 Merge pull request bitcoin#168
7277fd7 Remove GMP field implementation
e99c4c4 Merge pull request bitcoin#123
13278f6 Add explanation about how inversion can be avoided
ce7eb6f Optimize verification: avoid field inverse
a098f78 Merge pull request bitcoin#160
38acd01 Merge pull request bitcoin#165
6a59012 Make git ignore bench_recover when configured with benchmark enabled
1ba4a60 Configure options reorganization
3c0f246 Merge pull request bitcoin#157
808dd9b Merge pull request bitcoin#156
8dc75e9 Merge pull request bitcoin#158
28ade27 build: nuke bashisms
5190079 build: use subdir-objects for automake
8336040 build: disable benchmark by default

git-subtree-dir: src/secp256k1
git-subtree-split: 50cc6ab

glv2 referenced this pull request in glv2/peercoin Apr 22, 2015

dexX7 added a commit to dexX7/bitcoin that referenced this pull request Aug 26, 2015

Merge pull request bitcoin#160
abd12ff Restore FormatXXX() parameter names (dexX7)
f500922 Hide Omni Core RPCs which require wallet (dexX7)
46f6516 Remove requirement for enabled wallet (dexX7)
74df6eb Improve wallet related and other LOCKs (dexX7)
5586779 Use ENABLE_WALLET to wrap other Omni Core wallet parts (dexX7)
67d37eb Use ENABLE_WALLET to wrap wallet transaction cache (dexX7)
7a26c6b Use ENABLE_WALLET to wrap wallet fetch functions (dexX7)
5df3ed3 Move IsMyAddress into wallet related file (dexX7)
07d91b3 Move GetAddressLabel to wallet file (dexX7)
a39d6a9 Move CheckFee into wallet related file (dexX7)
d11ab9d Add helper to convert hex or address to public key (dexX7)
c6ecc53 Move SelectCoins into new wallet related file (dexX7)

TheBlueMatt added a commit to TheBlueMatt/bitcoin that referenced this pull request Oct 20, 2015

Update secp256k1
This contains the following two merges, as well as a few other changes:

Squashed 'src/secp256k1/' changes from 22f60a6..18f9f08

18f9f08 Pedersen commitments, borromean ring signatures, and ZK range proofs.
5161227 Add benchmark for ECDH multiplication
c40cb72 Expose API for constant time point multiplication
40adc7a Add constant-time `secp256k1_ecdh_point_multiply` for ECDH
ff9a397 Add zero/one tests to ecmult
729badf Merge pull request bitcoin#210
2d5a186 Apply effective-affine trick to precomp
4f9791a Effective affine addition in EC multiplication

git-subtree-dir: src/secp256k1
git-subtree-split: 18f9f0821c5a7795b760763c99d545af96a22775

Squashed 'src/secp256k1/' changes from b0210a9..22f60a6

22f60a6 Merge pull request bitcoin#245
61c1b1e Merge pull request bitcoin#190
d227579 Add scalar blinding and a secp256k1_context_randomize() call.
c146b4a Add bench_internal to gitignore.
9c4fb23 Add a secp256k1_fe_cmov unit test.
426fa52 Merge pull request bitcoin#243
d505a89 Merge pull request bitcoin#244
2d2707a travis: test i686 builds with gmp
cf7f702 travis: update to new build infrastructure
bb0ea50 Replace set/add with cmov in secp256k1_gej_add_ge.
f3d3519 Merge pull request bitcoin#241
5c2a4fa Fix memory leak in context unit test
14aacdc Merge pull request bitcoin#239
93226a5 secp256k1.c: Add missing DEBUG_CHECKs for sufficiently capable contexts
6099220 Merge pull request bitcoin#237
6066bb6 Fix typo: avg -> max
9688030 Merge pull request bitcoin#236
d899b5b Expose ability to deep-copy a context
3608c7f Merge pull request bitcoin#208
a9b6595 [API BREAK] Introduce explicit contexts
a0d3b89 Merge pull request bitcoin#233
9e8d89b Merge pull request bitcoin#234
65e70e7 Merge pull request bitcoin#235
5098f62 Improve documentation formatting consistency
4450e24 Add a comment about the avoidance of secret data in array indexes.
6534ee1 initialize variable
d5b53aa Merge pull request bitcoin#232
c01df1a Avoid some implicit type conversions to make C++ compilers happy.
bfe96ba Merge pull request bitcoin#231
33270bf Add a couple comments pointing to particular sections of RFC6979.
41603aa Merge pull request bitcoin#230
2632019 Brace all the if/for/while.
1897b8e Merge pull request bitcoin#229
efc571c Add simple testcases for signing with rfc6979 extra entropy.
1573a10 Add ability to pass extra entropy to rfc6979
3087bc4 Merge pull request bitcoin#228
d9b9f11 Merge pull request bitcoin#218
0065a8f Eliminate multiple-returns from secp256k1.c.
354ffa3 Make secp256k1_ec_pubkey_create reject oversized secrets.
27bc131 Silence some warnings from pedantic static analysis tools, improve compatibility with C++.
3b7ea63 Merge pull request bitcoin#221
f789c5b Merge pull request bitcoin#215
4bc273b Merge pull request bitcoin#222
137a8ec Merge pull request bitcoin#216
7c3771d Disable overlength-strings warnings.
8956111 use 128-bit hex seed
02efd06 Use RFC6979 for test PRNGs
ae55e85 Use faster byteswapping and avoid alignment-increasing casts.
443cd4b Get rid of hex format and some binary conversions
0bada0e Merge bitcoin#214: Improve signing API documentation & specification
8030d7c Improve signing API documentation & specification
7b2fc1c Merge bitcoin#213: Removed gotos, which are hard to trace and maintain.
11690d3 Removed gotos, which are hard to trace and maintain.
122a1ec Merge pull request bitcoin#205
035406d Merge pull request bitcoin#206
2d4cd53 Merge pull request bitcoin#161
34b898d Additional comments for the testing PRNG and a seeding fix.
6efd6e7 Some comments explaining some of the constants in the code.
ffccfd2 x86_64 assembly optimization for scalar_4x64
67cbdf0 Merge pull request bitcoin#207
039723d Benchmarks for all internal operations
6cc8425 Include a comment on secp256k1_ecdsa_sign explaining low-s.
f88343f Merge pull request bitcoin#203
d61e899 Add group operation counts
2473f17 Merge pull request bitcoin#202
b5bbce6 Some readme updates, e.g. removal of the GMP field.
f0d851e Merge pull request bitcoin#201
a0ea884 Merge pull request bitcoin#200
f735446 Convert the rest of the codebase to C89.
bf2e1ac Convert tests to C89. (also fixes a use of bare "inline" in field)
fc8285f Merge pull request bitcoin#199
fff412e Merge pull request bitcoin#197
4be8d6f Centralize the definition of uint128_t and use it uniformly.
d9543c9 Switch scalar code to C89.
fcc48c4 Remove the non-storage cmov
55422b6 Switch ecmult_gen to use storage types
41f8455 Use group element storage type in EC multiplications
e68d720 Add group element storage type
ff889f7 Field storage type
7137be8 Merge pull request bitcoin#196
0768bd5 Get rid of variable-length hex string conversions
e84e761 Merge pull request bitcoin#195
792bcdb Covert several more files to C89.
45cdf44 Merge pull request bitcoin#193
17db09e Merge pull request bitcoin#194
402878a fix ifdef/ifndef
25b35c7 Convert field code to strict C89 (+ long long, +__int128)
3627437 C89 nits and dead code removal.
a9f350d Merge pull request bitcoin#191
4732d26 Convert the field/group/ecdsa constant initialization to static consts
19f3e76 Remove unused secp256k1_fe_inner_{start, stop} functions
f1ebfe3 Convert the scalar constant initialization to static consts
50cc6ab Merge pull request bitcoin#178
941e221 Add tests for handling of the nonce function in signing.
10c81ff Merge pull request bitcoin#177
7688e34 Add magnitude limits to secp256k1_fe_verify to ensure that it's own tests function correctly.
4ee4f7a Merge pull request bitcoin#176
70ae0d2 Use secp256k1_fe_equal_var in secp256k1_fe_sqrt_var.
7767b4d Merge pull request bitcoin#175
9ab9335 Add a reference consistency test to ge_tests.
60571c6 Rework group tests
d26e26f Avoid constructing an invalid signature with probability 1:2^256.
b450c34 Merge pull request bitcoin#163
d57cae9 Merge pull request bitcoin#154
49ee0db Add _normalizes_to_zero_var variant
eed599d Add _fe_normalizes_to_zero method
d7174ed Weak normalization for secp256k1_fe_equal
0295f0a weak normalization
bbd5ba7 Use rfc6979 as default nonce generation function
b37fbc2 Implement SHA256 / HMAC-SHA256 / RFC6979.
c6e7f4e [API BREAK] Use a nonce-generation function instead of a nonce
cf0c48b Merge pull request bitcoin#169
603c33b Make signing fail if a too small buffer is passed.
6d16606 Merge pull request bitcoin#168
7277fd7 Remove GMP field implementation
e99c4c4 Merge pull request bitcoin#123
13278f6 Add explanation about how inversion can be avoided
ce7eb6f Optimize verification: avoid field inverse
a098f78 Merge pull request bitcoin#160
38acd01 Merge pull request bitcoin#165
6a59012 Make git ignore bench_recover when configured with benchmark enabled
1ba4a60 Configure options reorganization
3c0f246 Merge pull request bitcoin#157
808dd9b Merge pull request bitcoin#156
8dc75e9 Merge pull request bitcoin#158
28ade27 build: nuke bashisms
5190079 build: use subdir-objects for automake
8336040 build: disable benchmark by default
bccaf86 Merge pull request bitcoin#150
2a53a47 Merge pull request bitcoin#151
5f5a31f Merge pull request bitcoin#149
3907277 Merge pull request bitcoin#142
a3e0611 Enable tests in x86 travis builds
45da235 x86 builder
8bb0e93 Merge pull request bitcoin#155
971fe81 build: fix openssl detection for cross builds
f22d73e Explicitly access %0..%2 as 64-bit so we use the right registers for x32 ABI
e66d4d6 Avoid the stack in assembly and use explicit registers
cf7b2b4 Fix ECDSA message hashes to 32 bytes
056ad31 Really compile with -O3 by default
74ad63a Merge pull request bitcoin#146
9000458 Merge pull request bitcoin#145
1f46b00 build: fix __builtin_expect detection for clang
aaba2e0 Merge pull request bitcoin#136
8a0775c Merge pull request bitcoin#144
ee1eaa7 Merge pull request bitcoin#141
c88e2b8 Compile with -O3 by default
6558a26 Make the benchmarks print out stats
000bdf6 Rename bench_verify to bench_recovery
7c6fed2 Add a few more additional tests.
992e03b travis: add clang to the test matrix
b43b79a Merge pull request bitcoin#143
e06a924 Include time.h header for time().
8d11164 Add some additional tests.
3545627 Merge pull request bitcoin#118
6a9901e Merge pull request bitcoin#137
376b28b Merge pull request bitcoin#128
1728806 Merge pull request bitcoin#138
a5759c5 Check return value of malloc
39bd94d Variable time normalize
ad86bdf Merge pull request bitcoin#140
54b768c Another redundant secp256k1_fe_normalize
69dcaab Merge pull request bitcoin#139
1c29f2e Remove redundant secp256k1_fe_normalize from secp256k1_gej_add_ge_var.
2b9388b Remove unused secp256k1_fe_inv_all
f461b76 Allocate precomputation arrays on the heap
b2c9681 Make {mul,sqr}_inner use the same argument order as {mul,sqr}
6793505 Convert YASM code into inline assembly
f048615 Rewrite field assembly to match the C version
3ce74b1 Tweak precomputed table size for G

git-subtree-dir: src/secp256k1
git-subtree-split: 22f60a6

deadalnix pushed a commit to deadalnix/bitcoin that referenced this pull request Sep 18, 2016

deadalnix pushed a commit to deadalnix/bitcoin that referenced this pull request Jan 19, 2017

Merge pull request bitcoin#160
1ba4a60 Configure options reorganization (Pieter Wuille)

lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Dec 9, 2017

Merge pull request bitcoin#160 from hrobeers/timestamp-display
CWalletTx::GetTxTime() should return the peercoin txtime

classesjack pushed a commit to classesjack/bitcoin that referenced this pull request Jan 2, 2018

Merge pull request bitcoin#160 from qtumproject/earlz/fix-merge-bug
Fix staker bug introduced by a bad merge conflict resolution

artem-brazhnikov pushed a commit to Crowndev/crown-core that referenced this pull request Apr 27, 2018

Ashot
Merge branch '160-masternode-systemnode-install-script-small-rpc-pass…
…word-vulnerability' into 'master'

Resolve "masternode/systemnode install script - small RPC password vulnerability"

Closes bitcoin#160

See merge request crown/crown-core!105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment