Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: add key for Michael Ford (fanquake) to trusted keys list #16162

Merged
merged 1 commit into from Jun 8, 2019

Conversation

Projects
None yet
9 participants
@fanquake
Copy link
Member

commented Jun 7, 2019

Adding my key to the trusted keys list to join the maintainer group. I'll gain merge access and will continue with all triage/repo management work. I'll be focusing primarily on build system development with some guidance from theuni.

Some maintainer related discussion from the Core Dev meetup in Amsterdam is available here.

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Does that mean you are officially a maintainer? (Maybe mention that in the description, and which parts you are primarily going to maintain)

ACK 8081927

Only checked that the commit was signed with a key of "fanquake".
For some reason I never signed your key as part of a party, I think.

Show signature and timestamp

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK 8081927c33299e82498a85ac773c9f162e69ecaf

Only checked that the commit was signed with a key of "fanquake".
For some reason I never signed your key as part of a party, I think.
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUiRSAv/WhRxCHlWvpE8sgWMsFpE5T/5EK1xqPWECe19s8D5uE2llzYIIeO9wDW9
SF+HRHoGU9L7/fbb6rr6r2SUxXys9yFXsSsjaDnISeT3HKSwK/v3qi6pqAzM523D
ZGUPKcfyz9jFBwlfmKarZbV6bXxn9N9ibIGfiQg3+QMZUgV6RGThJKN3Niq7a0C3
IK7/+b/Nyp6PhH1mYccHZu/DWEz1NfSQ25SRMlHO/61O8dOih82wppydYZByVxAF
o2AfmLaO45yNNPxK9BFlpu4MLMPOZNYkiwbOaVwxb/gO1vf3Pwk23+D0JnWDUZOQ
zjF0m63fcndOsC60J327/XU4LP8862uCsP995EIwfTt6FLkNLPYXHDbketoeMw/Z
1fae1EX+4L70/AYYcGS3zGJUQgdULMv3kdJd17xUTR5CZ72ulVdsFTGds8HKWkOX
SNNFOR3Xk+OHkwEK3LCLs+xUmwmdzuHkbUdRn5JLRlQL4tRvq50RTz7Br5qJnV6+
st9uvYAr
=uYjG
-----END PGP SIGNATURE-----

Timestamp of file with hash 14bcdd110c0f72b7f23748e1c19ae6656e75575292f425f4eb1a09cae6786879 -

@achow101

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Concept ACK (didn't actually check the key yet)

@laanwj

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

ACK, this matches the key I have 8081927:

pub   rsa4096 2013-04-10 [SCEA]
      E777299FC265DD04793070EB944D35F9AC3DB76A
uid           [ unknown] Michael Ford (bitcoin-otc) <fanquake@gmail.com>
sub   rsa4096 2013-04-10 [SEA]
@meshcollider

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

ACK, this matches the key I have from the CoreDev New York 2018 keysigning party 8081927

@jnewbery

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Concept ACK. Please update OP to explain why you're doing this (to be a maintainer)

@jnewbery jnewbery added the Revise OP label Jun 7, 2019

@fanquake fanquake removed the Revise OP label Jun 7, 2019

@fanquake

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

@jnewbery Thanks, done.

@practicalswift

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Concept ACK

Welcome as a maintainer @fanquake! 🎉

@IlyasRidhuan

This comment has been minimized.

Copy link

commented Jun 8, 2019

ACK. 8081927 matches the key I have.

@DrahtBot DrahtBot added Needs rebase and removed Needs rebase labels Jun 8, 2019

@laanwj laanwj merged commit 8081927 into bitcoin:master Jun 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jun 8, 2019

Merge #16162: scripts: add key for Michael Ford (fanquake) to trusted…
… keys list

8081927 scripts: add key for fanquake to trusted keys list (fanquake)

Pull request description:

  Adding my key to the [trusted keys list](https://github.com/bitcoin/bitcoin/blob/master/contrib/verify-commits/trusted-keys) to join the maintainer group. I'll gain merge access and will continue with all triage/repo management work. I'll be focusing primarily on build system development with some guidance from theuni.

  Some maintainer related discussion from the Core Dev meetup in Amsterdam is available [here](http://diyhpl.us/wiki/transcripts/bitcoin-core-dev-tech/2019-06-06-maintainers/).

ACKs for commit 808192:
  MarcoFalke:
    ACK 8081927
  laanwj:
    ACK, this matches the key I have 8081927:
  meshcollider:
    ACK, this matches the key I have from the CoreDev New York 2018 keysigning party 8081927
  IlyasRidhuan:
    ACK. 8081927 matches the key I have.

Tree-SHA512: 63c390f5ede316263def2f9a897a1046d4ae58e4ea758f379164c6c5afce4928e2c9463fbcac004742838fd4ac1e48679e7a2a0f9095fd134a900f9064584056

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 9, 2019

Merge bitcoin#16162: scripts: add key for Michael Ford (fanquake) to …
…trusted keys list

8081927 scripts: add key for fanquake to trusted keys list (fanquake)

Pull request description:

  Adding my key to the [trusted keys list](https://github.com/bitcoin/bitcoin/blob/master/contrib/verify-commits/trusted-keys) to join the maintainer group. I'll gain merge access and will continue with all triage/repo management work. I'll be focusing primarily on build system development with some guidance from theuni.

  Some maintainer related discussion from the Core Dev meetup in Amsterdam is available [here](http://diyhpl.us/wiki/transcripts/bitcoin-core-dev-tech/2019-06-06-maintainers/).

ACKs for commit 808192:
  MarcoFalke:
    ACK 8081927
  laanwj:
    ACK, this matches the key I have 8081927:
  meshcollider:
    ACK, this matches the key I have from the CoreDev New York 2018 keysigning party bitcoin@8081927
  IlyasRidhuan:
    ACK. 8081927 matches the key I have.

Tree-SHA512: 63c390f5ede316263def2f9a897a1046d4ae58e4ea758f379164c6c5afce4928e2c9463fbcac004742838fd4ac1e48679e7a2a0f9095fd134a900f9064584056

@fanquake fanquake deleted the fanquake:fanquake_trusted_key branch Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.