Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addrdb: Avoid eating inodes - remove temporary files created by SerializeFileDB in case of errors #16212

Merged

Conversation

@practicalswift
Copy link
Member

commented Jun 14, 2019

Remove temporary files created in SerializeFileDB in case of errors.

Edit: Previously this was hit non-deterministically from the tests: that is no longer the case but the cleanup issue remains :-)

…determinism in unit tests.
@practicalswift practicalswift changed the title addrdb: Remove temporary files created in SerializeFileDB. Fixes non-determinism in unit tests. addrdb: Avoid eating inodes - remove temporary files created in SerializeFileDB in case of errors Jun 19, 2019
@practicalswift practicalswift changed the title addrdb: Avoid eating inodes - remove temporary files created in SerializeFileDB in case of errors addrdb: Avoid eating inodes - remove temporary files created by SerializeFileDB in case of errors Jun 19, 2019
@laanwj

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

code-review ACK d975338

@laanwj laanwj merged commit d975338 into bitcoin:master Jul 2, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Jul 2, 2019
…eated by SerializeFileDB in case of errors

d975338 addrdb: Remove temporary files created in SerializeFileDB. Fixes non-determinism in unit tests. (practicalswift)

Pull request description:

  Remove temporary files created in `SerializeFileDB` in case of errors.

  _Edit: Previously this was hit non-deterministically from the tests: that is no longer the case but the cleanup issue remains :-)_

ACKs for top commit:
  laanwj:
    code-review ACK d975338

Tree-SHA512: e72b74b8de411f433bd8bb354cacae07ab75a240db6232bc6a37802ccd8086bff5275ce3d196ddde033d8ab9e2794bb8f60eb83554af7ec2e9f91d6186cb4647
sidhujag added a commit to syscoin/syscoin that referenced this pull request Jul 3, 2019
…iles created by SerializeFileDB in case of errors

d975338 addrdb: Remove temporary files created in SerializeFileDB. Fixes non-determinism in unit tests. (practicalswift)

Pull request description:

  Remove temporary files created in `SerializeFileDB` in case of errors.

  _Edit: Previously this was hit non-deterministically from the tests: that is no longer the case but the cleanup issue remains :-)_

ACKs for top commit:
  laanwj:
    code-review ACK d975338

Tree-SHA512: e72b74b8de411f433bd8bb354cacae07ab75a240db6232bc6a37802ccd8086bff5275ce3d196ddde033d8ab9e2794bb8f60eb83554af7ec2e9f91d6186cb4647
luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Aug 23, 2019
…determinism in unit tests.

Github-Pull: bitcoin#16212
Rebased-From: d975338
@luke-jr luke-jr referenced this pull request Aug 23, 2019
fanquake added a commit to fanquake/bitcoin that referenced this pull request Aug 24, 2019
…determinism in unit tests.

Github-Pull: bitcoin#16212
Rebased-From: d975338
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Sep 3, 2019
fanquake added a commit to fanquake/bitcoin that referenced this pull request Sep 23, 2019
…determinism in unit tests.

Github-Pull: bitcoin#16212
Rebased-From: d975338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.