Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depends: Bump QT to LTS release 5.9.8 #16413

Open
wants to merge 1 commit into
base: master
from

Conversation

@THETCR
Copy link

commented Jul 18, 2019

This update is only a minor version but in contrary to 5.9.7 it's a LTS release.
It doesn't add any new functionality to Qt but fixes multiple security issues and bugs.
Including some race conditions and annoying bugs on macOS.

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Jul 18, 2019

Including some race conditions and annoying bugs on macOS

I think having some references would help testing.

@THETCR

This comment has been minimized.

Copy link
Author

commented Jul 18, 2019

I don't know if QTBUG-69955 is noticeable in the bitcoin-qt, but it is/was in other projects.
Nonetheless, having a LTS release is way more preferable if it's only a minor update.

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@hebasto

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

@fanquake

This comment has been minimized.

Copy link
Member

commented Jul 29, 2019

I don't know if QTBUG-69955 is noticeable in the bitcoin-qt, but it is/was in other projects.

It looks like we should already have that fix, as it was included in the 5.9.7 release?

Looking at the 5.9.8 fixes, I'm not sure if there's anything in there that affects the parts of Qt we use. Could you outline in the PR description which bug fixes we want?

In any case, the 5.9.9 LTS release is slated for Q4 of this year (likely before our 0.19.0 release), so if we haven't updated to the 5.12 LTS before then, we could update Qt to 5.9.9 at that point if there was a pressing reason too.

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

Gitian builds for commit febf3a8 (master):

Gitian builds for commit 0454597 (master and this pull):

@laanwj laanwj added this to the 0.19.0 milestone Jul 30, 2019

@laanwj

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

Can anyone with MacOSX please test if this makes a difference?

Will leave this open until short before 0.19 split-off—if there hasn't been a larger Qt bump by then, let's merge this.

@BlockMechanic

This comment has been minimized.

Copy link

commented Aug 11, 2019

Hi

I'd like to suggest a bump to Qt 5.12 LTS. Previous versions make multiple issue and require a lot of patches to work with aarch64. The major contributing factor for my advocating going this route is Google deprecating both 32-bit apps and GCC in favour of Clang as mentioned here :- #16110 (comment)

Some patches have already been proposed/merged such as #16110 which enables bitcoind to build but not QT (android) and this :- #13696 which does enable Qt but is now obsolete due to the move to clang.

@fanquake

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

I'd like to suggest a bump to Qt 5.12 LTS.

@BlockMechanic I've suggested that here, however there are other things to consider when bumping, such as dropping compatibility with older operating systems. Qt dropped support for macOS < 10.12 in 5.12.

@BlockMechanic

This comment has been minimized.

Copy link

commented Aug 12, 2019

I'd like to suggest a bump to Qt 5.12 LTS.

@BlockMechanic I've suggested that here, however there are other things to consider when bumping, such as dropping compatibility with older operating systems. Qt dropped support for macOS < 10.12 in 5.12.

Ok thanks , I had already begun checking it out :)

@Sjors

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

ACK 0c6054f. Lightly tested on macOS 10.14.6. Not really sure what difference would matter on macOS.

Where does QT announce which versions are LTS? I'm fine with holding off merging, and instead bumping to whichever 5.9 version is the most recent closer to the 0.19 branch-off.

@hebasto

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

@Sjors

Where does QT announce which versions are LTS?

https://blog.qt.io/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.