New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Remove downgrading warning in release notes, per 0.18 branch #16455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 77773ed
|
||
From 0.17.0 onwards, macOS <10.10 is no longer supported. 0.17.0 is | ||
From 0.17.0 onwards, macOS <10.10 is no longer supported. 0.17.0 is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps: s/From 0.17.0 onwards,/Since 0.17.0,/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the "onward" wording, so I'll keep it for now unless other reviewers want me to change it as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the onwards wording is ok.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 77773ed
The downgrade warning section is no longer present in the 0.18 branch release notes and the wording changes look ok.
|
||
From 0.17.0 onwards, macOS <10.10 is no longer supported. 0.17.0 is | ||
From 0.17.0 onwards, macOS <10.10 is no longer supported. 0.17.0 is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the onwards wording is ok.
….18 branch 77773ed doc: Remove downgrading warning in release notes, per 0.18 branch (MarcoFalke) Pull request description: Same as b702e37 (on the 0.18 branch) ACKs for top commit: jonatack: ACK 77773ed fanquake: ACK 77773ed Tree-SHA512: 4d7e598dd739f930f1a712f8647dfc7514e9fdef501f91bc0ee86642aa260360dc560335cd0f16b38b88b2a6b9cfc2df10b6418a371cf02137285d893e1cea30
Same as b702e37 (on the 0.18 branch)