New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small UX update for optionsdialog #1649
Conversation
Diapolo
commented
Aug 2, 2012
- add enableApplyButton() and disableApplyButton() to optionsdialog.{h/cpp}
- they are used to ensure the Ok button does not get disabled, when Apply needs to be disabled (standard UX should allow Ok always to dismiss the dialog and only disable it, when we have a faulty proxy IP)
- disable Apply after initially loading the settings, as nothing new needs to be saved
- remove orphan settings from optionsdialog.ui that are default anyway
- add enableApplyButton() and disableApplyButton() to optionsdialog.{h/cpp} - they are used to ensure the Ok button does not get disabled, when Apply needs to be disabled (standard UX should allow Ok always to dismiss the dialog and only disable it, when we have a faulty proxy IP) - disable Apply after initially loading the settings, as nothing new needs to be saved - remove orphan settings from optionsdialog.ui that are default anyway
@@ -147,6 +150,16 @@ void OptionsDialog::setMapper() | |||
mapper->addMapping(ui->displayAddresses, OptionsModel::DisplayAddresses); | |||
} | |||
|
|||
void OptionsDialog::enableApplyButton() | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why define a function (two functions, even) for what is one (pretty straightforward) line anyway? Or do you plan to extend this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used in connect(mapper, SIGNAL(viewModified()), this, SLOT(enableApplyButton()));
, where I can't use ui->applyButton->setEnabled(true);
directly, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. It sucks that connect(mapper, SIGNAL(viewModified()), ui, SLOT(setEnabled(true)));
is not possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So everything fine here :)?
The following is an automatic comment from the Bitcoin Pull Tester. This pull passed automatic sanity-tests! |
small UX update for optionsdialog