Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Mention other ways to conserve memory on compilation #16586

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@MarcoFalke
Copy link
Member

commented Aug 12, 2019

Related to:

  • Building requires >1GB memory #6658

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:1908-docLowMem branch from faa2b7a to ffffbd2 Aug 12, 2019

@fanquake fanquake added the Docs label Aug 12, 2019

@emilengler

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

ACK ffffbd2
Maybe it is better to replace gcc with g++

@jamesob

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

ACK

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:1908-docLowMem branch from ffffbd2 to fa7789f Aug 12, 2019

@MarcoFalke

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

Maybe it is better to replace gcc with g++

Removed the backticks instead, since they are not supposed to represent a command.

@instagibbs

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

ACK fa7789f

@kristapsk
Copy link
Contributor

left a comment

ACK fa7789f

@fanquake fanquake merged commit fa7789f into bitcoin:master Aug 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

fanquake added a commit that referenced this pull request Aug 14, 2019

Merge #16586: doc: Mention other ways to conserve memory on compilation
fa7789f doc: Mention other ways to conserve memory on compilation (MarcoFalke)

Pull request description:

  Related to:

  *  Building requires >1GB memory #6658

ACKs for top commit:
  instagibbs:
    ACK fa7789f
  kristapsk:
    ACK fa7789f

Tree-SHA512: 828593de9cfa9f9027c6c8e97abe95e3fad9f2ff50e6512808a8950de4a1f9ea901e724edfb96d7119224c3e38a136e60cb798b34ef682c585a7951e02124a3a

@MarcoFalke MarcoFalke deleted the MarcoFalke:1908-docLowMem branch Aug 14, 2019

@elichai

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

You should also set CFLAGS=-O2 not just CXXFLAGS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.