Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa: Run tests with UPnP disabled #16646

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@fanquake
Copy link
Member

commented Aug 19, 2019

This replaces #16560 by adding upnp=0 to bitcoin.conf rather than passing it to nodes.

Needed for builds configured with --enable-upnp-default

You can test this change using:

./configure --enable-upnp-default && make -j6 && test/functional/test_runner.py feature_config_args.py

on master the test will fail without this change.

Needed for builds configured with --enable-upnp-default
@practicalswift

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

ACK b168dd3 -- diff looks correct

@laanwj laanwj changed the title Bugfix: QA: Run tests with UPnP disabled qa: Run tests with UPnP disabled Aug 19, 2019
laanwj added a commit that referenced this pull request Aug 19, 2019
b168dd3 Bugfix: QA: Run tests with UPnP disabled (Luke Dashjr)

Pull request description:

  This replaces #16560 by adding `upnp=0` to `bitcoin.conf` rather than passing it to nodes.

  > Needed for builds configured with --enable-upnp-default

  You can test this change using:
  ```bash
  ./configure --enable-upnp-default && make -j6 && test/functional/test_runner.py feature_config_args.py
  ```

  on master the test will fail without this change.

ACKs for top commit:
  practicalswift:
    ACK b168dd3 -- diff looks correct

Tree-SHA512: e639dd480dda2cffa19a679018c4bd7e4bd4d0f5e3001d6b407b833e3c166bde98b201063e267b8e45f8a20b0d53ec8bc028bec806b2357f9a7ba314cc4e2d07
@laanwj laanwj merged commit b168dd3 into bitcoin:master Aug 19, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fanquake fanquake deleted the fanquake:add_upnp_to_test_framework_conf branch Aug 19, 2019
luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Aug 23, 2019
Needed for builds configured with --enable-upnp-default

Github-Pull: bitcoin#16646
Rebased-From: b168dd3
@luke-jr luke-jr referenced this pull request Aug 23, 2019
fanquake added a commit to fanquake/bitcoin that referenced this pull request Aug 24, 2019
Needed for builds configured with --enable-upnp-default

Github-Pull: bitcoin#16646
Rebased-From: b168dd3
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Sep 3, 2019
Needed for builds configured with --enable-upnp-default

Github-Pull: bitcoin#16646
Rebased-From: b168dd3
fanquake added a commit to fanquake/bitcoin that referenced this pull request Sep 23, 2019
Needed for builds configured with --enable-upnp-default

Github-Pull: bitcoin#16646
Rebased-From: b168dd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.