Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
qt: Replace deprecated QSignalMapper by lambda expressions #16706
I didn't know about that. Thank you.
FWIW, this PR is a part of my work on warnings raised during compiling on Bionic against Qt 5.13.
Gitian builds for commit db67101 (master):
Gitian builds for commit e05543d (master and this pull):
Aug 29, 2019
Post merge ACK. This totally gets rid of the flood of warnings on macOs with QT 5.13 from homebrew. It's also shorter and more readable. Tested that external explorer links still work, as well as banning peers.
Building with depends (QT 5.9.7) also works, though this still throws trillions of (unrelated) warnings.