build: make building protobuf optional in depends #16871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
fanquake
force-pushed
the
depends_no_protobuf_by_default
branch
from
4eb0502
to
8600e92
Compare
Those that want to build it can now pass PROTOBUF=1.
fanquake
force-pushed
the
depends_no_protobuf_by_default
branch
from
8600e92
to
107e030
Compare
|
code review ACK 107e030 |
|
Gitian builds for commit 4bfef0d (master):
Gitian builds for commit 86e97fc (master and this pull):
|
|
tACK 107e030 on macOS 10.14. When I build depends with |
laanwj
added a commit
that referenced
this pull request
Sep 16, 2019
107e030 build: make protobuf optional in depends (fanquake) ff6122f doc: clarify protobuf build requirements (fanquake) Pull request description: As mentioned by dongcarl in #15584 (comment), make building `protobuf` optional in depends. With this change it will only be built if you pass `PROTOBUF=1`. ACKs for top commit: laanwj: code review ACK 107e030 Sjors: tACK 107e030 on macOS 10.14. When I build depends with `PROTOBUF=1` then `./configure` has `bip70` enabled. Tree-SHA512: 49bc247a6879aaf55b943a3d0b930544ddef1e69a481955a8bebe0b02c9ad0fe168b93025f34168334cef34bb567478eb98eacab62ba909f2f64fb21119c71b8
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 16, 2019
107e030 build: make protobuf optional in depends (fanquake) ff6122f doc: clarify protobuf build requirements (fanquake) Pull request description: As mentioned by dongcarl in bitcoin#15584 (comment), make building `protobuf` optional in depends. With this change it will only be built if you pass `PROTOBUF=1`. ACKs for top commit: laanwj: code review ACK 107e030 Sjors: tACK 107e030 on macOS 10.14. When I build depends with `PROTOBUF=1` then `./configure` has `bip70` enabled. Tree-SHA512: 49bc247a6879aaf55b943a3d0b930544ddef1e69a481955a8bebe0b02c9ad0fe168b93025f34168334cef34bb567478eb98eacab62ba909f2f64fb21119c71b8
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Apr 2, 2020
Summary: Backport of core [[bitcoin/bitcoin#16871 | PR16871]]. The logic is reversed wrt core since we enable bip70 by default. Depends on D5637. Test Plan: make build-osx NO_PROTOBUF=1 Check that protobuf is not built. ../configure --prefix=$PWD/../depends/x86_64-apple-darwin16 Check in the summary that bip70 is disabled: with bip70 = no Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5640
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Aug 17, 2020
Summary: Backport of core [[bitcoin/bitcoin#16871 | PR16871]]. The logic is reversed wrt core since we enable bip70 by default. Depends on D5637. Test Plan: make build-osx NO_PROTOBUF=1 Check that protobuf is not built. ../configure --prefix=$PWD/../depends/x86_64-apple-darwin16 Check in the summary that bip70 is disabled: with bip70 = no Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5640
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Dec 7, 2021
107e030 build: make protobuf optional in depends (fanquake) ff6122f doc: clarify protobuf build requirements (fanquake) Pull request description: As mentioned by dongcarl in bitcoin#15584 (comment), make building `protobuf` optional in depends. With this change it will only be built if you pass `PROTOBUF=1`. ACKs for top commit: laanwj: code review ACK 107e030 Sjors: tACK 107e030 on macOS 10.14. When I build depends with `PROTOBUF=1` then `./configure` has `bip70` enabled. Tree-SHA512: 49bc247a6879aaf55b943a3d0b930544ddef1e69a481955a8bebe0b02c9ad0fe168b93025f34168334cef34bb567478eb98eacab62ba909f2f64fb21119c71b8
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Dec 15, 2021
107e030 build: make protobuf optional in depends (fanquake) ff6122f doc: clarify protobuf build requirements (fanquake) Pull request description: As mentioned by dongcarl in bitcoin#15584 (comment), make building `protobuf` optional in depends. With this change it will only be built if you pass `PROTOBUF=1`. ACKs for top commit: laanwj: code review ACK 107e030 Sjors: tACK 107e030 on macOS 10.14. When I build depends with `PROTOBUF=1` then `./configure` has `bip70` enabled. Tree-SHA512: 49bc247a6879aaf55b943a3d0b930544ddef1e69a481955a8bebe0b02c9ad0fe168b93025f34168334cef34bb567478eb98eacab62ba909f2f64fb21119c71b8
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Dec 15, 2021
107e030 build: make protobuf optional in depends (fanquake) ff6122f doc: clarify protobuf build requirements (fanquake) Pull request description: As mentioned by dongcarl in bitcoin#15584 (comment), make building `protobuf` optional in depends. With this change it will only be built if you pass `PROTOBUF=1`. ACKs for top commit: laanwj: code review ACK 107e030 Sjors: tACK 107e030 on macOS 10.14. When I build depends with `PROTOBUF=1` then `./configure` has `bip70` enabled. Tree-SHA512: 49bc247a6879aaf55b943a3d0b930544ddef1e69a481955a8bebe0b02c9ad0fe168b93025f34168334cef34bb567478eb98eacab62ba909f2f64fb21119c71b8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by dongcarl in #15584 (comment), make building
protobufoptional in depends. With this change it will only be built if you passPROTOBUF=1.