-
Notifications
You must be signed in to change notification settings - Fork 36.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wallet: Change default address type to bech32 #16884
Conversation
Concept ACK, same is already in bitcoin-qt so this makes it just more coherent. |
I think you can also revert fa5a4cd |
Concept ACK |
Concept ACK. Needs a release note. |
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Concept ACK |
1b6ca7d
to
97efb8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
97efb8c
to
b4e8375
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK.
@@ -0,0 +1,4 @@ | |||
The wallet now by default uses bech32 addresses when using RPC, and creates native segwit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop "when using RPC"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QT already by default does bech32, so I believe this is more accurate?
Concept ACK |
1 similar comment
Concept ACK |
b4e8375
to
691cc72
Compare
in commit 9721429: Does not compile because you forgot to remove the // Always fall back to bech32 in the gui case |
691cc72
to
b631464
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK b631464 looks good, did not compile
Show signature and timestamp
Signature:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
ACK b631464f54e4b826a52c04161492fec89a711866 looks good, did not compile
-----BEGIN PGP SIGNATURE-----
iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUiFOQv6A3gQDyHxmmYJuYzWi4MYaCerjQ+6wUjnTgFvkDGsGo70m2yRf9zfb1Tx
vw24BOYmqq8C1eHHDl3JixPTxpYfemdu2tdyNdzM+QLJD4pzcZFGYsGlqpqu6GLO
TUV7MOIbzlBmJ1G4kIQFFeF3cJhcTeYPhQaNLqPbsGhvdpy4CDb8Mj2co7KSFVs3
kieSDVKK4VMbs52srHJel3WLNTW5HORfsTM7CrwAb0TMUn/HwjDmgPcZdZYhYZxU
0K7St/Dtf0NAYdDCxInzyXfMUkhbcE9w4hye2jbtnOIGbZH+DCfsjuaW/ITdmfxW
4HzP7dbYg5IRrY304ohKTgC6P3m+F7Qw57R7hrpo90sgdIy/m0k4E89Ifv08pP8O
bHWzPYOv560vX6zNRoVjztY6/yNwWceJ9/SX6L6otx4D28fsTJleDfEWTHIebqKk
gp71AUYwNDrSvcyvu/uayp93U1enrmS97pq1kz3eR6irRL1G6hLsCVDcgfW9Y9U2
3qR5na16
=QpM0
-----END PGP SIGNATURE-----
Timestamp of file with hash 0979dba1d91ee3700a115a74e85034597fa657a8e983564f537c26f83c78585e -
I'm going to revert my change-mimicking revert due to unpopularity on IRC. |
b631464
to
71d4edd
Compare
updated to reduce PR scope to just the default address option |
Concept ACK |
re-ACK 71d4edd (only change is restore mimick behavior) Show signature and timestampSignature:
Timestamp of file with hash |
Could add a commit to bump |
ACK 71d4edd
Please do this in a follow-up PR. |
71d4edd Add release note for bech32 by default in wallet (Gregory Sanders) b34f018 Revert "gui: Generate bech32 addresses by default (take 2, fixup)" (Gregory Sanders) f50785a Change default address type to bech32 (Gregory Sanders) Pull request description: ACKs for top commit: MarcoFalke: re-ACK 71d4edd (only change is restore mimick behavior) laanwj: ACK 71d4edd Tree-SHA512: 3c49a1b51c49f3a762ad08985167ca1b89b0177ae20ab6d5883f1f74dde7a155921c1b855a842199bbf32f563c56b33f8b603bc842637bdcb121001023d454b6
71d4edd Add release note for bech32 by default in wallet (Gregory Sanders) b34f018 Revert "gui: Generate bech32 addresses by default (take 2, fixup)" (Gregory Sanders) f50785a Change default address type to bech32 (Gregory Sanders) Pull request description: ACKs for top commit: MarcoFalke: re-ACK 71d4edd (only change is restore mimick behavior) laanwj: ACK 71d4edd Tree-SHA512: 3c49a1b51c49f3a762ad08985167ca1b89b0177ae20ab6d5883f1f74dde7a155921c1b855a842199bbf32f563c56b33f8b603bc842637bdcb121001023d454b6
No description provided.