Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: Change sendcoins dialogue Yes to Send #16964

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@instagibbs
Copy link
Member

instagibbs commented Sep 25, 2019

It's more self-explanatory, matches "cancel" better, and makes future extensions such as #16944 more directly understandable to the user.

@DrahtBot DrahtBot added the GUI label Sep 25, 2019
@promag

This comment has been minimized.

Copy link
Member

promag commented Sep 25, 2019

ACK

@DrahtBot

This comment has been minimized.

Copy link
Contributor

DrahtBot commented Sep 25, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #16966 (ui: make send a wizard by Sjors)
  • #16944 (gui: create PSBT with watch-only wallet by Sjors)
  • #15987 (Wallet, GUI: Warn when sending to already-used Bitcoin addresses by luke-jr)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@emilengler

This comment has been minimized.

Copy link
Contributor

emilengler commented Sep 25, 2019

Concept ACK

@Sjors

This comment has been minimized.

Copy link
Member

Sjors commented Sep 26, 2019

Trivial code review ACK a649cc6. I also used Send in #16966 (ui - make send a wizard)

@fanquake fanquake changed the title GUI: Change sendcoins dialogue Yes to Send gui: Change sendcoins dialogue Yes to Send Sep 26, 2019
@fanquake

This comment has been minimized.

Copy link
Member

fanquake commented Sep 26, 2019

master (fdfaeb6):

master

This PR (a649cc6):

16964

Copy link
Member

jonatack left a comment

Code review ACK a649cc6

"Send" is more clear and removes any possible ambiguity.

@Sjors

This comment has been minimized.

Copy link
Member

Sjors commented Sep 26, 2019

Note that bump fee uses the same dialog.

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Sep 26, 2019

Definitely better.
ACK a649cc6

We don't have a translation for bare "Send" yet, so this has to go in after the 0.19 split.

@fanquake fanquake added this to the 0.20.0 milestone Sep 26, 2019
MarcoFalke added a commit that referenced this pull request Oct 2, 2019
a649cc6 Change sendcoins dialogue Yes to Send (Gregory Sanders)

Pull request description:

  It's more self-explanatory, matches "cancel" better, and makes future extensions such as #16944 more directly understandable to the user.

ACKs for top commit:
  Sjors:
    Trivial code review ACK a649cc6. I also used Send in #16966 (`ui - make send a wizard`)
  laanwj:
    ACK a649cc6
  jonatack:
    Code review ACK a649cc6

Tree-SHA512: fe4993bc7ac653d28f3d399ade046bcfd405511aec06ff041bb5aef47e0736faf3e3112a6db660cd761af56392dc6b97f2c2341ed3eff4490079c5eb8a0d465a
@MarcoFalke MarcoFalke merged commit a649cc6 into bitcoin:master Oct 2, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
sidhujag added a commit to syscoin/syscoin that referenced this pull request Oct 2, 2019
a649cc6 Change sendcoins dialogue Yes to Send (Gregory Sanders)

Pull request description:

  It's more self-explanatory, matches "cancel" better, and makes future extensions such as bitcoin#16944 more directly understandable to the user.

ACKs for top commit:
  Sjors:
    Trivial code review ACK a649cc6. I also used Send in bitcoin#16966 (`ui - make send a wizard`)
  laanwj:
    ACK a649cc6
  jonatack:
    Code review ACK a649cc6

Tree-SHA512: fe4993bc7ac653d28f3d399ade046bcfd405511aec06ff041bb5aef47e0736faf3e3112a6db660cd761af56392dc6b97f2c2341ed3eff4490079c5eb8a0d465a
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Nov 15, 2019
MarkLTZ added a commit to litecoinz-core/litecoinz that referenced this pull request Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants
You can’t perform that action at this time.