[BIP 174] PSBT version, proprietary, and xpub fields #17034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
instagibbs
approved these changes
Oct 8, 2019
| unsigned char type = key[0]; | ||
| // Type is compact size uint at beginning of key | ||
| VectorReader skey(s.GetType(), s.GetVersion(), key, 0); | ||
| uint64_t type = ReadCompactSize(skey); |
There was a problem hiding this comment.
Manually inspected that all the fields with constant types are now being written with compact size, but I would like to be more systematic somehow in the future.
achow101
force-pushed
the
bip174-extensions
branch
2 times, most recently
from
9ca1f8b
to
674e638
Compare
luke-jr
reviewed
Jan 5, 2020
achow101
force-pushed
the
bip174-extensions
branch
from
674e638
to
dd1a5ca
Compare
This was referenced Feb 11, 2020
achow101
force-pushed
the
bip174-extensions
branch
from
dd1a5ca
to
7fbaf8b
Compare
achow101
force-pushed
the
bip174-extensions
branch
from
7fbaf8b
to
7795804
Compare
This was referenced Mar 26, 2020
This was referenced Apr 13, 2020
achow101
force-pushed
the
bip174-extensions
branch
from
7795804
to
19200a7
Compare
darosior
reviewed
Dec 8, 2021
achow101
force-pushed
the
bip174-extensions
branch
from
198b080
to
e75e52f
Compare
|
re-utACK e75e52f |
darosior
reviewed
Dec 10, 2021
…to psbt module SerializeToVector, UnserializeFromVector, DeserializeHDKeypaths, and SerializeHDKeypaths were in sign.h where PSBT was originally implemented. Since all of the PSBT serialization has moved to its own file, these functions should follow.
CExtPubKey does not store the version bytes for the extended public key. We store these so that a CExtPubKey can be serialized and deserialized with the same version bytes.
achow101
force-pushed
the
bip174-extensions
branch
from
e75e52f
to
8152117
Compare
|
Code review ACK 8152117 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 11, 2021
…elds 8152117 Merge global xpubs in joinpsbts and combinepsbts (Andrew Chow) d8043dd Add global xpub test vectors from BIP (Andrew Chow) 35670df Add global_xpubs to decodepsbt (Andrew Chow) 9038485 Implement serializations for PSBT_GLOBAL_XPUB (Andrew Chow) c5c63b8 Implement operator< for KeyOriginInfo and CExtPubKey (Andrew Chow) d3dbb16 Separate individual HD Keypath serialization into separate functions (Andrew Chow) a69332f Store version bytes and be able to serialize them in CExtPubKey (Andrew Chow) 5fdaf6a moveonly: Move (Un)Serialize(To/From)Vector, (De)SerializeHDKeypaths to psbt module (Andrew Chow) 94065cc Test for proprietary field (Andrew Chow) a4cf810 Output proprietary type info in decodepsbt (Andrew Chow) aebe758 Implement PSBT proprietary type (Andrew Chow) 10ba0b5 Output psbt version in decodepsbt (Andrew Chow) df84fa9 Add GetVersion helper to PSBT (Andrew Chow) c3eb416 Implement PSBT versions (Andrew Chow) 3235847 Types are compact size uints (Andrew Chow) Pull request description: Implements the changes to BIP 174 proposed in bitcoin/bips#849 and bitcoin/bips#784 Implements `PSBT_GLOBAL_VERSION`, `PSBT_GLOBAL_PROPRIETARY`, `PSBT_IN_PROPRIETARY`, `PSBT_OUT_PROPRIETARY`, and `PSBT_GLOBAL_XPUB`. The `PSBT_GLOBAL_XPUB` changes are merged in from bitcoin#16463. Also includes the test vectors added to BIP 174 for these fields. A number of additional changes to keypath and xpub serialization are made to support `PSBT_GLOBAL_XPUB`. ACKs for top commit: laanwj: Code review ACK 8152117 Tree-SHA512: bd71c3f26030fc23824e76a30d3d346a753e1db224ecee163d6813348feb52d3f4cf4e739a4699e2cff381197ce2a7ea4a92a054f2c3e1db579e91e92a0945e0
RandyMcMillan
pushed a commit
to RandyMcMillan/mempool-tab
that referenced
this pull request
Dec 23, 2021
… xpub fields 4ca1ec3 Merge global xpubs in joinpsbts and combinepsbts (Andrew Chow) fed4bd5 Add global xpub test vectors from BIP (Andrew Chow) 958a2f7 Add global_xpubs to decodepsbt (Andrew Chow) feb2cae Implement serializations for PSBT_GLOBAL_XPUB (Andrew Chow) 9a017e8 Implement operator< for KeyOriginInfo and CExtPubKey (Andrew Chow) ff65018 Separate individual HD Keypath serialization into separate functions (Andrew Chow) 7e14f42 Store version bytes and be able to serialize them in CExtPubKey (Andrew Chow) ddd0620 moveonly: Move (Un)Serialize(To/From)Vector, (De)SerializeHDKeypaths to psbt module (Andrew Chow) e436636 Test for proprietary field (Andrew Chow) 624cd15 Output proprietary type info in decodepsbt (Andrew Chow) eafafc3 Implement PSBT proprietary type (Andrew Chow) 736907a Output psbt version in decodepsbt (Andrew Chow) 742a811 Add GetVersion helper to PSBT (Andrew Chow) 3355928 Implement PSBT versions (Andrew Chow) 6a76e80 Types are compact size uints (Andrew Chow) Pull request description: Implements the changes to BIP 174 proposed in bitcoin/bips#849 and bitcoin/bips#784 Implements `PSBT_GLOBAL_VERSION`, `PSBT_GLOBAL_PROPRIETARY`, `PSBT_IN_PROPRIETARY`, `PSBT_OUT_PROPRIETARY`, and `PSBT_GLOBAL_XPUB`. The `PSBT_GLOBAL_XPUB` changes are merged in from #16463. Also includes the test vectors added to BIP 174 for these fields. A number of additional changes to keypath and xpub serialization are made to support `PSBT_GLOBAL_XPUB`. ACKs for top commit: laanwj: Code review ACK 4ca1ec3 Tree-SHA512: bd71c3f26030fc23824e76a30d3d346a753e1db224ecee163d6813348feb52d3f4cf4e739a4699e2cff381197ce2a7ea4a92a054f2c3e1db579e91e92a0945e0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the changes to BIP 174 proposed in bitcoin/bips#849 and bitcoin/bips#784
Implements
PSBT_GLOBAL_VERSION,PSBT_GLOBAL_PROPRIETARY,PSBT_IN_PROPRIETARY,PSBT_OUT_PROPRIETARY, andPSBT_GLOBAL_XPUB. ThePSBT_GLOBAL_XPUBchanges are merged in from #16463.Also includes the test vectors added to BIP 174 for these fields.
A number of additional changes to keypath and xpub serialization are made to support
PSBT_GLOBAL_XPUB.