Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bip174 extensions #17034

Open
wants to merge 5 commits into
base: master
from
Open

Bip174 extensions #17034

wants to merge 5 commits into from

Conversation

@achow101
Copy link
Member

achow101 commented Oct 3, 2019

Implements the changes to BIP 174 proposed in bitcoin/bips#849

@DrahtBot

This comment has been minimized.

Copy link
Contributor

DrahtBot commented Oct 3, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #18098 (scripted-diff: Add missing spaces in RPCResult, Normalize type names by MarcoFalke)
  • #17809 (rpc: Auto-format RPCResult by MarcoFalke)
  • #16463 ([BIP 174] Implement serialization support for GLOBAL_XPUB field. by achow101)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@fanquake fanquake requested review from instagibbs and meshcollider Oct 8, 2019
Copy link
Member

instagibbs left a comment

cursory review ACK

unsigned char type = key[0];
// Type is compact size uint at beginning of key
VectorReader skey(s.GetType(), s.GetVersion(), key, 0);
uint64_t type = ReadCompactSize(skey);

This comment has been minimized.

Copy link
@instagibbs

instagibbs Oct 8, 2019

Member

Manually inspected that all the fields with constant types are now being written with compact size, but I would like to be more systematic somehow in the future.

@achow101 achow101 force-pushed the achow101:bip174-extensions branch from 9ca1f8b to 674e638 Oct 9, 2019
@DrahtBot DrahtBot removed the Needs rebase label Oct 9, 2019
@jonatack jonatack mentioned this pull request Oct 10, 2019
src/psbt.h Outdated Show resolved Hide resolved
@DrahtBot

This comment has been minimized.

Copy link
Contributor

DrahtBot commented Feb 17, 2020

Needs rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.