Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: Add placeholder text to the sign message field #17186

Merged
merged 1 commit into from Oct 18, 2019

Conversation

@Danny-Scott
Copy link
Contributor

Danny-Scott commented Oct 18, 2019

When using the sign message functionality I noticed the "message" field had no label or placeholder text to highlight what it's for.

I've added the placeholder text to match the tool tip to help it be more user friendly.

@hebasto

This comment has been minimized.

Copy link
Member

hebasto commented Oct 18, 2019

@Danny-Scott Thank you for contributing.
Could you add screenshots (master and with this PR) to the OP?

@Danny-Scott

This comment has been minimized.

Copy link
Contributor Author

Danny-Scott commented Oct 18, 2019

Screenshots attached - Thanks, hopefully the first of many contributions.

Master
master

PR
Danny-PR

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Oct 18, 2019

ACK

@DrahtBot DrahtBot added the GUI label Oct 18, 2019
Copy link
Member

hebasto left a comment

ACK f956160, tested on Linux Mint 19.2.

master (4daadce):
Screenshot from 2019-10-18 13-07-07

PR (f956160):
Screenshot from 2019-10-18 13-19-18

src/qt/forms/signverifymessagedialog.ui Outdated Show resolved Hide resolved
@hebasto

This comment has been minimized.

Copy link
Member

hebasto commented Oct 18, 2019

Re-ACK 0b27b3e, could squash please?

@Danny-Scott Danny-Scott force-pushed the Danny-Scott:oct-2019-sign-message branch from 0b27b3e to 7005d6a Oct 18, 2019
@Danny-Scott

This comment has been minimized.

Copy link
Contributor Author

Danny-Scott commented Oct 18, 2019

Rebased and squashed.

Thanks

@hebasto

This comment has been minimized.

Copy link
Member

hebasto commented Oct 18, 2019

Re-ACK 7005d6a

Copy link
Member

fanquake left a comment

ACK 7005d6a

master (b9b58f8):
master

pr (7005d6a):
pr

fanquake added a commit that referenced this pull request Oct 18, 2019
7005d6a gui: Add placeholder text to the sign message field (Danny-Scott)

Pull request description:

  When using the sign message functionality I noticed the "message" field had no label or placeholder text to highlight what it's for.

  I've added the placeholder text to match the tool tip to help it be more user friendly.

ACKs for top commit:
  hebasto:
    Re-ACK 7005d6a
  fanquake:
    ACK 7005d6a

Tree-SHA512: 17fe51c134f6373d8d5f9ca98b15bd936da4e61aa5258ceb5d318575d49b43cbfde6f4c3f720eb5928206902e6ba52811ba08737a03c95224e45dabc947d9d11
@fanquake fanquake merged commit 7005d6a into bitcoin:master Oct 18, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Nov 15, 2019
MarkLTZ added a commit to litecoinz-core/litecoinz that referenced this pull request Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.