Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

random: remove call to RAND_screen() (Windows only) #17191

Merged
merged 1 commit into from Oct 21, 2019

Conversation

@fanquake
Copy link
Member

fanquake commented Oct 18, 2019

Follow up to #17151 where there were multiple calls to also remove our call to RAND_screen().

Follow up to #17151 where
there were multiple calls to also remove our call to RAND_screen().
@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented Oct 18, 2019

unsigned ACK e892f96

@emilengler

This comment has been minimized.

Copy link
Contributor

emilengler commented Oct 18, 2019

ACK

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Oct 19, 2019

ACK e892f96

Though after this I'd prefer to wait for #17165 and rip OpenSSL usage out all at once, instead of statement for statement 😄

@fanquake fanquake mentioned this pull request Oct 19, 2019
@DrahtBot

This comment has been minimized.

Copy link
Contributor

DrahtBot commented Oct 20, 2019

Gitian builds for commit b6e34af (master):

Gitian builds for commit c3d6db0 (master and this pull):

laanwj added a commit that referenced this pull request Oct 21, 2019
e892f96 random: remove call to RAND_screen() (Windows only) (fanquake)

Pull request description:

  Follow up to #17151 where there were multiple calls to also remove our call to RAND_screen().

ACKs for top commit:
  MarcoFalke:
    unsigned ACK e892f96
  laanwj:
    ACK e892f96

Tree-SHA512: 1b846016d91e8113f90466b61fcaf0574edb6b4726eba1947549e2ac28907e1318d893f7b303e756f19730c8507c79b10e08d54b97153224b585ff1e0ac1953e
@laanwj laanwj merged commit e892f96 into bitcoin:master Oct 21, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fanquake fanquake deleted the fanquake:remove_openssl_rand_screen branch Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.