tests: Add unit testing for the CompressScript function #17220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theStack
reviewed
Oct 23, 2019
src/test/compress_tests.cpp
Outdated
Comment on lines
72
to
74
| CScript script; | ||
| script.clear(); | ||
| script << OP_DUP << OP_HASH160 << ToByteVector(pubkey.GetID()) << OP_EQUALVERIFY << OP_CHECKSIG; |
There was a problem hiding this comment.
nit: This could be put in one line by immediately assigning the script on the declaration: CScript script = CScript() << OP_DUP ..... << OP_CHECKSIG (also applies to the other three functions).
There was a problem hiding this comment.
wouldn't assigning the script on the declaration remove the opportunity to call .clear() on it?
There was a problem hiding this comment.
I don't think that calling .clear() is needed here at all, since newly constructed CScripts are empty anyway?
There was a problem hiding this comment.
I don't think we need to clear() it, since the default constructor CScript() constructs a (logically) empty CScript.
|
ACK, thanks for adding tests. |
dongcarl
approved these changes
Oct 23, 2019
src/test/compress_tests.cpp
Outdated
Comment on lines
72
to
74
| CScript script; | ||
| script.clear(); | ||
| script << OP_DUP << OP_HASH160 << ToByteVector(pubkey.GetID()) << OP_EQUALVERIFY << OP_CHECKSIG; |
There was a problem hiding this comment.
I don't think we need to clear() it, since the default constructor CScript() constructs a (logically) empty CScript.
adamjonas
force-pushed
the
add_compress_test_cases
branch
2 times, most recently
from
4d3cdda
to
7756f06
Compare
adamjonas
force-pushed
the
add_compress_test_cases
branch
from
7756f06
to
b05ec41
Compare
|
ACK b05ec41 |
laanwj
added a commit
that referenced
this pull request
Oct 25, 2019
b05ec41 Add unit testing for the CompressScript functions (marcaiaf) Pull request description: Salvaging #15104 which adds unit tests for CompressScript function in `compressor.cpp` Tested following cases for the CScript: - CKeyID - CScriptID - Uncompressed CPubKey (of size: 65) - Compressed CPubKey (of size: 32) ACKs for top commit: theStack: ACK b05ec41 Tree-SHA512: 7e23ace39383122802dfe5f7d38190d772f5db4045a67b7a9bd4c06797a17e0cdc41d6fac92d448057eb7df50172155dc824587c16c68c79fd1a4de37b772001
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 30, 2020
Summary: This is a backport of Core [[bitcoin/bitcoin#17220 | PR17220]] Test Plan: `ninja && ninja check` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Subscribers: majcosta Differential Revision: https://reviews.bitcoinabc.org/D8192
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Nov 1, 2021
…unction b05ec41 Add unit testing for the CompressScript functions (marcaiaf) Pull request description: Salvaging bitcoin#15104 which adds unit tests for CompressScript function in `compressor.cpp` Tested following cases for the CScript: - CKeyID - CScriptID - Uncompressed CPubKey (of size: 65) - Compressed CPubKey (of size: 32) ACKs for top commit: theStack: ACK bitcoin@b05ec41 Tree-SHA512: 7e23ace39383122802dfe5f7d38190d772f5db4045a67b7a9bd4c06797a17e0cdc41d6fac92d448057eb7df50172155dc824587c16c68c79fd1a4de37b772001
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Nov 3, 2021
…unction b05ec41 Add unit testing for the CompressScript functions (marcaiaf) Pull request description: Salvaging bitcoin#15104 which adds unit tests for CompressScript function in `compressor.cpp` Tested following cases for the CScript: - CKeyID - CScriptID - Uncompressed CPubKey (of size: 65) - Compressed CPubKey (of size: 32) ACKs for top commit: theStack: ACK bitcoin@b05ec41 Tree-SHA512: 7e23ace39383122802dfe5f7d38190d772f5db4045a67b7a9bd4c06797a17e0cdc41d6fac92d448057eb7df50172155dc824587c16c68c79fd1a4de37b772001
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
…unction b05ec41 Add unit testing for the CompressScript functions (marcaiaf) Pull request description: Salvaging bitcoin#15104 which adds unit tests for CompressScript function in `compressor.cpp` Tested following cases for the CScript: - CKeyID - CScriptID - Uncompressed CPubKey (of size: 65) - Compressed CPubKey (of size: 32) ACKs for top commit: theStack: ACK bitcoin@b05ec41 Tree-SHA512: 7e23ace39383122802dfe5f7d38190d772f5db4045a67b7a9bd4c06797a17e0cdc41d6fac92d448057eb7df50172155dc824587c16c68c79fd1a4de37b772001
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salvaging #15104 which adds unit tests for CompressScript function in
compressor.cppTested following cases for the CScript: