rpc: set default bip32derivs to true for psbt methods #17264

Sjors · 2019-10-26T10:10:01Z

In #13557 (review) I recommended not including bip32 deriviation by default in PSBTs:

Bit of a privacy issue: let's say person A and B are about to spend from a multisig address, sending everything to person A. Person A gives their address to person B, their wallet wallet creates a PSBT, but doesn't sign it. Wallet A then calls walletprocesspsbt which signs it and spontaneously adds the master_fingerprint and bip32 path. Same issue with walletcreatefundedpsbt.

Adding bip32_derivs should probably be opt-in.

In practice I find this default quite annoying because I forget it and end up with a confused hardware wallet.

More importantly, in the multisig example I provided, it's actually essential for the other side to know the derivation details (in addition to an xpub). This allows them to check that change is going to an address you can still co-sign for (because the spending policy is unchanged except for an index).

DrahtBot · 2019-10-26T11:55:29Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

refactor: consolidate sendmany and sendtoaddress code #18202 (refactor: consolidate sendmany and sendtoaddress code by Sjors)
wallet: Pass in transactions and messages for signing instead of exporting the private keys #18115 (wallet: Pass in transactions and messages for signing instead of exporting the private keys by achow101)
"PSBT Operations" dialog #18027 ("PSBT Operations" dialog by gwillen)
Allow fundrawtransaction and walletcreatefundedpsbt to take external inputs #17211 (Allow fundrawtransaction and walletcreatefundedpsbt to take external inputs by achow101)
UI external signer support (e.g. hardware wallet) #16549 ([WIP] UI external signer support (e.g. hardware wallet) by Sjors)
External signer support - Wallet Box edition #16546 ([WIP] External signer support - Wallet Box edition by Sjors)
Native Descriptor Wallets using DescriptorScriptPubKeyMan #16528 (Native Descriptor Wallets using DescriptorScriptPubKeyMan by achow101)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

jb55 · 2019-10-27T12:10:15Z

Concept/Approach ACK 29a21c9

instagibbs · 2019-11-14T16:28:16Z

imo the privacy ship has sailed on PSBTs, we have no functionality to remove data from PSBTs yet, and no conceptual workflow to manage such a thing. We have thought about this in context of Confidential Assets as well dealing with blinded amounts/assets. It's complicated.

Therefore, concept ACK

sipa · 2019-12-04T19:17:26Z

Privacy in PSBTs is hard; if done properly, it should probably mean having different domains of participants/signers, and filtering out private information when crossing boundaries. I don't think it's simple, or something that can be delegated to users using a flag at signing time (because usually you'd want to reveal that derivation information to e.g. your hardware wallet but not to other signers).

Concept ACK.

achow101 · 2019-12-04T19:31:21Z

ACK 29a21c9

sipa · 2020-01-31T02:43:11Z

Code review ACK 29a21c9. The changes look straightforward, but a test that these fields are filled would be nice.

Sjors · 2020-01-31T09:39:15Z

I added a commit with a test demonstrating the default behavior. Good call, because I discovered #18039 in the process. Update: it's a feature, not a bug :-)

Sjors · 2020-02-20T15:30:02Z

I won't rebase, to preserve ACKs, but I did run the test suite locally on a rebased version.

jonatack

ACK 5bad792 code review, built, ran tests, inspected/messed around with/pprinted values from the new tests. Thanks for adding the tests.

Edit: also built and ran tests after rebasing onto current master @ eb3c6b0

jonatack · 2020-02-20T16:35:35Z

I wonder if a deprecation process would be good here. Edit: probably not; this fixes an annoyance.

instagibbs

logic ACK, leaving a question about the test

instagibbs · 2020-02-20T17:45:51Z

test/functional/rpc_psbt.py

@@ -192,12 +192,20 @@ def run_test(self):
        psbt_orig = self.nodes[0].createpsbt([{"txid":txid1,  "vout":vout1}, {"txid":txid2, "vout":vout2}], {self.nodes[0].getnewaddress():25.999})

        # Update psbts, should only have data for one input and not the other
-        psbt1 = self.nodes[1].walletprocesspsbt(psbt_orig)['psbt']
+        psbt1 = self.nodes[1].walletprocesspsbt(psbt_orig, False, "ALL")['psbt']


why is it important that signing is False and specified sighash flag??

Because otherwise the test runs into #18039

instagibbs · 2020-02-20T21:21:03Z

utACK 5bad792

meshcollider

utACK 5bad792

…thods 5bad792 [test] PSBT RPC: check that bip32_derivs are present by default (Sjors Provoost) 29a21c9 [rpc] set default bip32derivs to true for psbt methods (Sjors Provoost) Pull request description: In bitcoin#13557 (review) I recommended not including bip32 deriviation by default in PSBTs: > _Bit of a privacy issue_: let's say person A and B are about to spend from a multisig address, sending everything to person A. Person A gives their address to person B, their wallet wallet creates a PSBT, but doesn't sign it. Wallet A then calls `walletprocesspsbt` which signs it and _spontaneously adds the master_fingerprint and bip32 path_. Same issue with `walletcreatefundedpsbt`. > > Adding `bip32_derivs` should probably be opt-in. In practice I find this default quite annoying because I forget it and end up with a confused hardware wallet. More importantly, in the multisig example I provided, it's actually essential for the other side to know the derivation details (in addition to an xpub). This allows them to check that change is going to an address you can still co-sign for (because the spending policy is unchanged except for an index). ACKs for top commit: instagibbs: utACK bitcoin@5bad792 jonatack: ACK 5bad792 code review, built, ran tests, inspected/messed around with/pprinted values from the new tests. Thanks for adding the tests. meshcollider: utACK 5bad792 Tree-SHA512: 22ad71dda96856060a96758c4ae7aafa22d5e9efba30e0c8287c711e7579849bd72593cbc0f41a2e9e8821315d78bda04e848dbb006283b841b2795e2faebcfd

Summary: * [rpc] set default bip32derivs to true for psbt methods * [test] PSBT RPC: check that bip32_derivs are present by default This is a backport of Core [[bitcoin/bitcoin#17264 | PR17264]] Some test were skipped due to the fact that they had to do with RBF Test Plan: ninja all check-all Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D8104

…thods 5bad792 [test] PSBT RPC: check that bip32_derivs are present by default (Sjors Provoost) 29a21c9 [rpc] set default bip32derivs to true for psbt methods (Sjors Provoost) Pull request description: In bitcoin#13557 (review) I recommended not including bip32 deriviation by default in PSBTs: > _Bit of a privacy issue_: let's say person A and B are about to spend from a multisig address, sending everything to person A. Person A gives their address to person B, their wallet wallet creates a PSBT, but doesn't sign it. Wallet A then calls `walletprocesspsbt` which signs it and _spontaneously adds the master_fingerprint and bip32 path_. Same issue with `walletcreatefundedpsbt`. > > Adding `bip32_derivs` should probably be opt-in. In practice I find this default quite annoying because I forget it and end up with a confused hardware wallet. More importantly, in the multisig example I provided, it's actually essential for the other side to know the derivation details (in addition to an xpub). This allows them to check that change is going to an address you can still co-sign for (because the spending policy is unchanged except for an index). ACKs for top commit: instagibbs: utACK bitcoin@5bad792 jonatack: ACK 5bad792 code review, built, ran tests, inspected/messed around with/pprinted values from the new tests. Thanks for adding the tests. meshcollider: utACK 5bad792 Tree-SHA512: 22ad71dda96856060a96758c4ae7aafa22d5e9efba30e0c8287c711e7579849bd72593cbc0f41a2e9e8821315d78bda04e848dbb006283b841b2795e2faebcfd

[rpc] set default bip32derivs to true for psbt methods

29a21c9

fanquake added the RPC/REST/ZMQ label Oct 26, 2019

Sjors mentioned this pull request Oct 26, 2019

bumpfee: Return PSBT when wallet has privkeys disabled #16373

Merged

fanquake changed the title ~~[rpc] set default bip32derivs to true for psbt methods~~ rpc: set default bip32derivs to true for psbt methods Oct 26, 2019

[test] PSBT RPC: check that bip32_derivs are present by default

5bad792

jonatack reviewed Feb 20, 2020

View reviewed changes

instagibbs reviewed Feb 20, 2020

View reviewed changes

This was referenced Feb 21, 2020

External signer support - Wallet Box edition #16546

Merged

UI external signer support (e.g. hardware wallet) #16549

Closed

refactor: consolidate sendmany and sendtoaddress code #18202

Merged

meshcollider reviewed Feb 25, 2020

View reviewed changes

meshcollider merged commit 31c0006 into bitcoin:master Feb 25, 2020

Sjors deleted the 2019/10/bip32_derivs branch February 25, 2020 10:52

MarkLTZ mentioned this pull request Apr 4, 2020

Bitcoin PR tracking litecoinz-core/litecoinz#14

Closed

bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rpc: set default bip32derivs to true for psbt methods #17264

rpc: set default bip32derivs to true for psbt methods #17264

Sjors commented Oct 26, 2019

DrahtBot commented Oct 26, 2019 •

edited

Loading

jb55 commented Oct 27, 2019

instagibbs commented Nov 14, 2019

sipa commented Dec 4, 2019

achow101 commented Dec 4, 2019

sipa commented Jan 31, 2020

Sjors commented Jan 31, 2020 •

edited

Loading

Sjors commented Feb 20, 2020

jonatack left a comment •

edited

Loading

jonatack commented Feb 20, 2020 •

edited

Loading

instagibbs left a comment

instagibbs Feb 20, 2020

Sjors Feb 20, 2020

instagibbs commented Feb 20, 2020

meshcollider left a comment

rpc: set default bip32derivs to true for psbt methods #17264

rpc: set default bip32derivs to true for psbt methods #17264

Conversation

Sjors commented Oct 26, 2019

DrahtBot commented Oct 26, 2019 • edited Loading

Conflicts

jb55 commented Oct 27, 2019

instagibbs commented Nov 14, 2019

sipa commented Dec 4, 2019

achow101 commented Dec 4, 2019

sipa commented Jan 31, 2020

Sjors commented Jan 31, 2020 • edited Loading

Sjors commented Feb 20, 2020

jonatack left a comment • edited Loading

Choose a reason for hiding this comment

jonatack commented Feb 20, 2020 • edited Loading

instagibbs left a comment

Choose a reason for hiding this comment

instagibbs Feb 20, 2020

Choose a reason for hiding this comment

Sjors Feb 20, 2020

Choose a reason for hiding this comment

instagibbs commented Feb 20, 2020

meshcollider left a comment

Choose a reason for hiding this comment

DrahtBot commented Oct 26, 2019 •

edited

Loading

Sjors commented Jan 31, 2020 •

edited

Loading

jonatack left a comment •

edited

Loading

jonatack commented Feb 20, 2020 •

edited

Loading