Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nMinerConfirmationWindow not initialized #17433

Closed
wants to merge 1 commit into from

Conversation

@bitcoinVBR
Copy link

bitcoinVBR commented Nov 10, 2019

fix nMinerConfirmationWindow not initialized

@bitcoinVBR

This comment has been minimized.

Copy link
Author

bitcoinVBR commented Nov 11, 2019

not even a comment why this was closed?

@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented Nov 11, 2019

This stylistic change may make sense on its own, however it comes at a cost and risk for the project as a whole. The weak motivation for the change does not justify the burden that it places on the project. A burden could be any of the following:

  • Time spent on review
  • Accidental introduction of bugs
  • (Silent) merge conflicts, either in the branch or a backport branch. Those conflicts demand further developer and reviewer time or introduce bugs.

For more information about refactoring changes and stylistic cleanup, see

Generally, if the style is not mentioned nor enforced by the developer notes, we leave it up to the original author to pick whatever fits them best personally and then leave it that way until the line is touched for other reasons.

Let me know if you have any questions.

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Nov 12, 2019

This is now #17449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.