Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign uprpc: Expose block height of wallet transactions #17437
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
I can add a release note to list affected RPC. I think I'm also going to add tests for each affected RPC. |
This comment has been minimized.
This comment has been minimized.
Misssing update of the help doc |
This comment has been minimized.
This comment has been minimized.
Concept ACK |
This comment has been minimized.
This comment has been minimized.
Added release note, tests and updated help doc. |
This comment has been minimized.
This comment has been minimized.
ACK 36d9042 -- diff looks correct |
d5cfd7a
to
19d2f1a
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I expected this to be more expensive, but as it exposes data that is already in the internal data structures anyway, good idea! |
This comment has been minimized.
This comment has been minimized.
Kudos to @ariard and @ryanofsky! |
MarcoFalke
added a commit
that referenced
this pull request
Nov 12, 2019
a5e7795 rpc: Expose block height of wallet transactions (João Barbosa) Pull request description: Closes #17296. ACKs for top commit: practicalswift: ACK a5e7795 -- diff looks correct now (good catch @theStack!) theStack: ACK a5e7795 ryanofsky: Code review ACK a5e7795. Changes since last review getblockhash python test fixes, and removing the last hardcoded height Tree-SHA512: 57dcd0e4e7083f34016bf9cf8ef578fbfde49e882b6cd8623dd1c64716e096e62f6177a4c2ed94f5de304e751fe23fb9d11cf107a86fbf0a3c5f539cd2844916
luke-jr
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Nov 15, 2019
Github-Pull: bitcoin#17437 Rebased-From: a5e7795
This comment has been minimized.
This comment has been minimized.
Isn't this semi-redundant with "confirmations"? |
This comment has been minimized.
This comment has been minimized.
Lacking an atomic way to query the current height at the same time, this is slightly less error prone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
promag commentedNov 11, 2019
Closes #17296.