Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove straggling OpenSSL references from doc and build #17515

Merged
merged 4 commits into from Nov 19, 2019

Conversation

@laanwj
Copy link
Member

laanwj commented Nov 19, 2019

Some doc and build cleanups following #17265.

I intentionally left the libssl-dev install in gitian-win-signer.yml, as it's necessary for the ossl signer.

@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented Nov 19, 2019

ACK ea3c7e5 🗯

Show signature and timestamp

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK ea3c7e585c382998212fd7f41114462a8168a734 🗯
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUjCtQwApKSuDbs78h1GiIDic8IN5rPaf0Jz1AfgCB3XuXiTfKnqqD2X3eygA70u
ZLEjtYsZZkVGl7/K6FCmFm9i/8rzy/hTVdDPG9siKdb2Bzks7Z5k/nfuJ/rH7txD
xWoyLsvAmmZsJFmSPiNbUbVLqzGfud/O3E+pzkiyVB16rda+YOc821iNy6o/dF7H
lWaB0xT039KK4iSumM76QSwf9j2uUcQwNSiurUePXFV4G0Cf/koQNk0xIyLhTBaJ
LQ6yUMfRgBY/1PxlW8n36tDZFyoqgHZlQ1LvSs7mFe4Bwkmy/smvW6CCwSlyu9sC
rmqgarjXnqfPHWnpsQ7udYNoDCYV9ftAMBUnJLqFgWMFS8FmXizttyxBv0bCV92z
yp0YV2CVOCtY4inJdKnoJsVwamXJxsN/bfoZ3odk3ddTVTzaoDVHDL1NNwz9xcB9
2dHeNZeOWKhqXc8wd2oRbW/jXWI98UT2rVV/1QJ0akT6bNNIjOKmuRezJUQEJ+Gb
Hk6X+5cD
=x0IZ
-----END PGP SIGNATURE-----

Timestamp of file with hash b5c714005a6e23f2aa4e746b8a72917971f3a2e0a1c8939e4e37e5fab9adb343 -

@jamesob

This comment has been minimized.

Copy link
Member

jamesob commented Nov 19, 2019

ACK ea3c7e5

Copy link
Member

fanquake left a comment

ACK ea3c7e5 - thanks.

@practicalswift

This comment has been minimized.

Copy link
Member

practicalswift commented Nov 19, 2019

ACK ea3c7e5 - nice!

fanquake added a commit that referenced this pull request Nov 19, 2019
ea3c7e5 test: Remove libssl-dev packages from CI scripts (Wladimir J. van der Laan)
7ea5526 test: remove lsan suppression for libcrypto (Wladimir J. van der Laan)
2d70665 build: remove libcrypto as internal dependency in libbitcoinconsensus.pc (Wladimir J. van der Laan)
278751e doc: Remove ssl as a required dependency from build-unix (Wladimir J. van der Laan)

Pull request description:

  Some doc and build cleanups following #17265.

  I intentionally left the libssl-dev install in `gitian-win-signer.yml`, as it's necessary for the ossl signer.

ACKs for top commit:
  MarcoFalke:
    ACK ea3c7e5 🗯
  jamesob:
    ACK ea3c7e5
  practicalswift:
    ACK ea3c7e5 - nice!
  fanquake:
    ACK ea3c7e5 - thanks.

Tree-SHA512: 67ea35bdd6d6e512d69e6734713534c88cae033a2ed695677ea15c3e3d5ff570374e342775c88e60877fa43a19047853e7b2a433e2c9a4349a5c423726a7457e
@fanquake fanquake merged commit ea3c7e5 into bitcoin:master Nov 19, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
sidhujag added a commit to syscoin/syscoin that referenced this pull request Nov 19, 2019
…d build

ea3c7e5 test: Remove libssl-dev packages from CI scripts (Wladimir J. van der Laan)
7ea5526 test: remove lsan suppression for libcrypto (Wladimir J. van der Laan)
2d70665 build: remove libcrypto as internal dependency in libbitcoinconsensus.pc (Wladimir J. van der Laan)
278751e doc: Remove ssl as a required dependency from build-unix (Wladimir J. van der Laan)

Pull request description:

  Some doc and build cleanups following bitcoin#17265.

  I intentionally left the libssl-dev install in `gitian-win-signer.yml`, as it's necessary for the ossl signer.

ACKs for top commit:
  MarcoFalke:
    ACK ea3c7e5 🗯
  jamesob:
    ACK bitcoin@ea3c7e5
  practicalswift:
    ACK ea3c7e5 - nice!
  fanquake:
    ACK ea3c7e5 - thanks.

Tree-SHA512: 67ea35bdd6d6e512d69e6734713534c88cae033a2ed695677ea15c3e3d5ff570374e342775c88e60877fa43a19047853e7b2a433e2c9a4349a5c423726a7457e
@DrahtBot

This comment has been minimized.

Copy link
Contributor

DrahtBot commented Nov 19, 2019

Gitian builds

File commit 92db280
(master)
commit cecd82b
(master and this pull)
bitcoin-0.19.99-osx-unsigned.dmg 3a6b069a6c014944... 99e7990f621d9d16...
bitcoin-0.19.99-osx64.tar.gz e03f25de72831435... fe7665b00ad78070...
bitcoin-0.19.99-win64-debug.zip a690b8620445e833... 827475b4ea08dc97...
bitcoin-0.19.99-win64-setup-unsigned.exe aab0171807a00313... 7b5e34cfd1b0c87f...
bitcoin-0.19.99-win64.zip 0650dcc218863507... 9780bfd7044fe7cb...
bitcoin-0.19.99.tar.gz 246c4dd34cac401a... aa0b1621b0ea840f...
bitcoin-core-osx-0.20-res.yml b4495ecb8571910c... 454c7db45c1a2cd4...
bitcoin-core-win-0.20-res.yml d26b7df2f8d4faa6... 50ffef4518934621...
linux-build.log 4dcae05ac7d537c8... 97deef6cde4bc9ad...
osx-build.log b3ed782f1ff07966... 62214c97adf79d3c...
win-build.log a57601dfe340735a... 9bb73f287bccb2fc...
bitcoin-core-osx-0.20-res.yml.diff feddbbc28aaa8b41...
bitcoin-core-win-0.20-res.yml.diff 812e10a92f582d75...
linux-build.log.diff 1ef35104583470a1...
osx-build.log.diff 71c50c3c1fcecd32...
win-build.log.diff 871d486d0e785e84...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.