New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Qt binaries for GitHub Action CI job #17789
Conversation
Is there no way to hardcode the compiler version and then bump it together with the qt binaries? Otherwise it will be an endless cat-mouse game with appveyor/GitHub CI |
e352973
to
f030871
Compare
Also add new job version flag to allow vcpkg dependencies to be reinstalled whenever the job version flag is bumped.
f030871
to
3d472b2
Compare
@MarcoFalke how would it work with tracking the compiler version? The Qt binaries have to be rebuilt manually so even if the CI job detects the compiler on the build image has changed the best it can do is display a better error message. An additional complicating factor is Visual Studio is new getting updated as frequently as every two weeks. Not every update causes an ABI incompatibility. This particular issue has come about in Visual Studio 2019 16.4. The 16.1, 16.2, 16.3 and other minor version updates didn't break ABI compatibility. I don't think it's a coincidence that since "automated" CI became a thing DevOps roles have also taken off. The latter to look after the former. We're in the same boat. Over time I'd expect the "automated" CI's will start adding features like detecting vcpkg and other dependencies being out of date and automatically reinstalling. |
Testing... Step "Update vcpkg and install packages" took 23 minutes. |
@hebasto that's right. To resolve the libzmq ABI error the safest thing to do is to reinstall all the vcpkg packages. If the job is successful the vcpkg install directory will be cached and the step will be skipped on subsequent builds. |
@sipsorcery
It is weird, isn't it? |
That warning has always been there. I've never worried about it. I guess it's because the GitHub and Appveyor vm's load a 32 bit msvc build environment. It doesn't affect the code generation since the build job set the target architecture as 64 bit. Seems there's an easy fix. I'll test it out. |
The first job is successful. Something wrong with cache? UPDATE
|
Instead of |
@sipsorcery The excerpt from the log of "Run actions/cache@v1" step on a subsequent build:
|
From GitHub Actions Docs:
|
Concept ACK, I guess |
Concept ACK. |
This PR is not ready for merge. The job version mechanism is not working. The GithHub cache action does not work the way I expected. I'm still working on a fix. |
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Closed in favour of #17793. |
0b5a366 ci: Update vcpkg cache on MSBuild update (Hennadii Stepanov) b6fa752 ci: Update Qt binaries for GitHub Actions (Hennadii Stepanov) Pull request description: On master (0cda557) Visual Studio update in GitHub Actions CI virtual environment could break a build as the `vcpkg` cache is not updated accordingly (see #17788). This PR: - force vcpkg cache update on MSBuild update - is an alternative to #17789 - fixes #17788 ACKs for top commit: fanquake: ACK 0b5a366 Tree-SHA512: b9e69cb5184a3bbee4c7b14ac35985145a9fd3403d0e449d79f15c18e9660cafec495d639f5f730e0c69dde5f4a3d7590b4e42d385e794cd02add1f4e3b785e7
…ild update 0b5a366 ci: Update vcpkg cache on MSBuild update (Hennadii Stepanov) b6fa752 ci: Update Qt binaries for GitHub Actions (Hennadii Stepanov) Pull request description: On master (0cda557) Visual Studio update in GitHub Actions CI virtual environment could break a build as the `vcpkg` cache is not updated accordingly (see bitcoin#17788). This PR: - force vcpkg cache update on MSBuild update - is an alternative to bitcoin#17789 - fixes bitcoin#17788 ACKs for top commit: fanquake: ACK 0b5a366 Tree-SHA512: b9e69cb5184a3bbee4c7b14ac35985145a9fd3403d0e449d79f15c18e9660cafec495d639f5f730e0c69dde5f4a3d7590b4e42d385e794cd02add1f4e3b785e7
…ild update 0b5a366 ci: Update vcpkg cache on MSBuild update (Hennadii Stepanov) b6fa752 ci: Update Qt binaries for GitHub Actions (Hennadii Stepanov) Pull request description: On master (0cda557) Visual Studio update in GitHub Actions CI virtual environment could break a build as the `vcpkg` cache is not updated accordingly (see bitcoin#17788). This PR: - force vcpkg cache update on MSBuild update - is an alternative to bitcoin#17789 - fixes bitcoin#17788 ACKs for top commit: fanquake: ACK 0b5a366 Tree-SHA512: b9e69cb5184a3bbee4c7b14ac35985145a9fd3403d0e449d79f15c18e9660cafec495d639f5f730e0c69dde5f4a3d7590b4e42d385e794cd02add1f4e3b785e7
…ild update 0b5a366 ci: Update vcpkg cache on MSBuild update (Hennadii Stepanov) b6fa752 ci: Update Qt binaries for GitHub Actions (Hennadii Stepanov) Pull request description: On master (0cda557) Visual Studio update in GitHub Actions CI virtual environment could break a build as the `vcpkg` cache is not updated accordingly (see bitcoin#17788). This PR: - force vcpkg cache update on MSBuild update - is an alternative to bitcoin#17789 - fixes bitcoin#17788 ACKs for top commit: fanquake: ACK 0b5a366 Tree-SHA512: b9e69cb5184a3bbee4c7b14ac35985145a9fd3403d0e449d79f15c18e9660cafec495d639f5f730e0c69dde5f4a3d7590b4e42d385e794cd02add1f4e3b785e7
…ild update 0b5a366 ci: Update vcpkg cache on MSBuild update (Hennadii Stepanov) b6fa752 ci: Update Qt binaries for GitHub Actions (Hennadii Stepanov) Pull request description: On master (0cda557) Visual Studio update in GitHub Actions CI virtual environment could break a build as the `vcpkg` cache is not updated accordingly (see bitcoin#17788). This PR: - force vcpkg cache update on MSBuild update - is an alternative to bitcoin#17789 - fixes bitcoin#17788 ACKs for top commit: fanquake: ACK 0b5a366 Tree-SHA512: b9e69cb5184a3bbee4c7b14ac35985145a9fd3403d0e449d79f15c18e9660cafec495d639f5f730e0c69dde5f4a3d7590b4e42d385e794cd02add1f4e3b785e7
…ild update 0b5a366 ci: Update vcpkg cache on MSBuild update (Hennadii Stepanov) b6fa752 ci: Update Qt binaries for GitHub Actions (Hennadii Stepanov) Pull request description: On master (0cda557) Visual Studio update in GitHub Actions CI virtual environment could break a build as the `vcpkg` cache is not updated accordingly (see bitcoin#17788). This PR: - force vcpkg cache update on MSBuild update - is an alternative to bitcoin#17789 - fixes bitcoin#17788 ACKs for top commit: fanquake: ACK 0b5a366 Tree-SHA512: b9e69cb5184a3bbee4c7b14ac35985145a9fd3403d0e449d79f15c18e9660cafec495d639f5f730e0c69dde5f4a3d7590b4e42d385e794cd02add1f4e3b785e7
…ild update 0b5a366 ci: Update vcpkg cache on MSBuild update (Hennadii Stepanov) b6fa752 ci: Update Qt binaries for GitHub Actions (Hennadii Stepanov) Pull request description: On master (0cda557) Visual Studio update in GitHub Actions CI virtual environment could break a build as the `vcpkg` cache is not updated accordingly (see bitcoin#17788). This PR: - force vcpkg cache update on MSBuild update - is an alternative to bitcoin#17789 - fixes bitcoin#17788 ACKs for top commit: fanquake: ACK 0b5a366 Tree-SHA512: b9e69cb5184a3bbee4c7b14ac35985145a9fd3403d0e449d79f15c18e9660cafec495d639f5f730e0c69dde5f4a3d7590b4e42d385e794cd02add1f4e3b785e7
Also add new job version flag to allow vcpkg dependencies to be reinstalled whenever the job version flag is bumped.
Fix for #17788.