Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: Shortcut to close RPC Console #17795

Conversation

emilengler
Copy link
Contributor

@emilengler emilengler commented Dec 23, 2019

Credits to promag.
Similar to #16515 with a macOS addition.

This PR makes it possible to close the RPC Console (like a terminal) with Ctrl+D. On macOS it will close with Ctrl+W as it is a more common syntax there.

Co-authored-by: João Barbosa <joao.paulo.barbosa@gmail.com>
@fanquake fanquake added the GUI label Dec 23, 2019
@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Dec 24, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #17636 (qt: Add -guisettingsdir option by emilengler)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@luke-jr
Copy link
Member

@luke-jr luke-jr commented Jan 3, 2020

Doesn't Ctrl-D work in macOS Terminal too?

I think it makes more sense to just do Ctrl-D here, and let the other PR add Ctrl-W too.

@emilengler
Copy link
Contributor Author

@emilengler emilengler commented Jan 3, 2020

Doesn't Ctrl-D work in macOS Terminal too?

Well yes but actually no
It terminates the shell process but the window remains open asying that the process was terminated successfully

@fanquake
Copy link
Member

@fanquake fanquake commented Mar 5, 2020

Going to close with the same rationale as #16515. This hasn't seen any renewed interest and I think the project has more important things to work on. Ideally all of this kind of thing would be handled by Qt.

@fanquake fanquake closed this Mar 5, 2020
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants