Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[wip] build: Switch from C++11 to C++17 #17904
Switch from C++11 to C++17.
Fixes #16684 ("Discussion: upgrading to C++17").
This is work in progress and thus not ready to merge. C++17 is optimistically planned for 0.21.0.
Left to do:
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
I'd say let's stick to build changes only here. code changes can come in a follow up PR
EDIT: I meant if and when it will happen. I think it's still early to even change the build system for C++17 support.
fanquake left a comment
I think it's a bit too early to open this PR. Having a branch with the changes is interesting, and would make a good discussion point for #16684.
However as a PR, it's going to be a long time until this is might be merged, and in the interim it's going to conflict with a lot of other PRs, and generate a lot of noise.
I've left a couple comments inline where you've dropped our changes to the
Closing PR for now: I see your point about