Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: Shortcut to close ModalOverlay #17998

Merged

Conversation

@emilengler
Copy link
Contributor

emilengler commented Jan 24, 2020

This adds the shortcut Esc to hide the ModalOverlay.
The motivation is that it is annoying to always move the cursor to "Hide" when quickly testing something in the GUI with an outdated chain.

@emilengler emilengler force-pushed the emilengler:2020-01-escape-modaloverlay branch from b4cb0dd to 1a638e1 Jan 24, 2020
@emilengler emilengler changed the title gui: Shortcut to close modaloverlay gui: Shortcut to close ModalOverlay Jan 24, 2020
@DrahtBot DrahtBot added the GUI label Jan 24, 2020
@hebasto

This comment has been minimized.

Copy link
Member

hebasto commented Jan 25, 2020

@emilengler
A similar functionality is implemented already by @promag in #12616. Are there any cases when #12616 solution does not work for you?

@promag

This comment has been minimized.

Copy link
Member

promag commented Jan 27, 2020

ACK, why not? I know I've tried several times to close with ESC..

Copy link
Contributor

kristapsk left a comment

ACK 1a638e1. Agree with @promag, Esc feels more natural than Enter here.

Copy link
Member

jonasschnelli left a comment

ACK 1a638e1

jonasschnelli added a commit that referenced this pull request Jan 27, 2020
1a638e1 gui: Shortcut to close ModalOverlay (Emil Engler)

Pull request description:

  This adds the shortcut `Esc` to hide the ModalOverlay.
  The motivation is that it is annoying to always move the cursor to "Hide" when quickly testing something in the GUI with an outdated chain.

ACKs for top commit:
  kristapsk:
    ACK 1a638e1. Agree with @promag, Esc feels more natural than Enter here.
  jonasschnelli:
    ACK 1a638e1

Tree-SHA512: ea764349ec145ce9a34cbc66c3ac0eace9233a3fb3e9c22694a77882478afa22d4e686ce2c1d7b3938f6769f96ba995577b0216ba9d98954dcf3e55d2187f2e0
@jonasschnelli jonasschnelli merged commit 1a638e1 into bitcoin:master Jan 27, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
sidhujag added a commit to syscoin/syscoin that referenced this pull request Jan 27, 2020
1a638e1 gui: Shortcut to close ModalOverlay (Emil Engler)

Pull request description:

  This adds the shortcut `Esc` to hide the ModalOverlay.
  The motivation is that it is annoying to always move the cursor to "Hide" when quickly testing something in the GUI with an outdated chain.

ACKs for top commit:
  kristapsk:
    ACK 1a638e1. Agree with @promag, Esc feels more natural than Enter here.
  jonasschnelli:
    ACK 1a638e1

Tree-SHA512: ea764349ec145ce9a34cbc66c3ac0eace9233a3fb3e9c22694a77882478afa22d4e686ce2c1d7b3938f6769f96ba995577b0216ba9d98954dcf3e55d2187f2e0
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.