Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Output a descriptor in createmultisig and addmultisigaddress #18032

Merged
merged 1 commit into from Feb 9, 2020

Conversation

@achow101
Copy link
Member

achow101 commented Jan 30, 2020

Give a descriptor from createmultisig and addmultisigaddress.

Extracted from #16528 with addmultisgaddress and tests added.

@achow101 achow101 force-pushed the achow101:createms-descriptor branch from f529fe0 to f62edde Jan 30, 2020
@sipa

This comment has been minimized.

Copy link
Member

sipa commented Jan 30, 2020

Code review ACK, briefly tested.

Why didn't we think of this earlier?

@achow101 achow101 force-pushed the achow101:createms-descriptor branch from f62edde to 2be46e8 Jan 30, 2020
@DrahtBot

This comment has been minimized.

Copy link
Contributor

DrahtBot commented Jan 30, 2020

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@achow101 achow101 force-pushed the achow101:createms-descriptor branch from 2be46e8 to 2080fe5 Jan 31, 2020
@sipa

This comment has been minimized.

Copy link
Member

sipa commented Jan 31, 2020

Also add a mention to doc/descriptors.md?

@achow101

This comment has been minimized.

Copy link
Member Author

achow101 commented Jan 31, 2020

Added a mention in descriptors.md

@achow101 achow101 force-pushed the achow101:createms-descriptor branch from 2080fe5 to 2bd5285 Jan 31, 2020
@achow101 achow101 force-pushed the achow101:createms-descriptor branch from 2bd5285 to 19a354b Jan 31, 2020
@Sjors

This comment has been minimized.

Copy link
Member

Sjors commented Jan 31, 2020

tACK 19a354b

Copy link
Member

promag left a comment

Code review ACK 19a354b.

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Feb 9, 2020
Copy link
Member

meshcollider left a comment

utACK 19a354b

@MarcoFalke MarcoFalke changed the title Output a descriptor in createmultisig and addmultisigaddress rpc: Output a descriptor in createmultisig and addmultisigaddress Feb 9, 2020
@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented Feb 9, 2020

ACK 19a354b

MarcoFalke added a commit that referenced this pull request Feb 9, 2020
…sigaddress

19a354b Output a descriptor in createmultisig and addmultisigaddress (Andrew Chow)

Pull request description:

  Give a descriptor from `createmultisig` and `addmultisigaddress`.

  Extracted from #16528 with `addmultisgaddress` and tests added.

ACKs for top commit:
  Sjors:
    tACK 19a354b
  MarcoFalke:
    ACK 19a354b
  promag:
    Code review ACK 19a354b.
  meshcollider:
    utACK 19a354b

Tree-SHA512: e813125fbbc358ea8d45b1748de16a29a94efd83175b748fb8fa3b0bfc8e783ed36b6c554d84f5d4ead1ba252a83a3e937b6c3f75da7b8d3b4e55f94d6013771
@MarcoFalke MarcoFalke merged commit 19a354b into bitcoin:master Feb 9, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Feb 12, 2020
sidhujag added a commit to syscoin/syscoin that referenced this pull request Feb 18, 2020
…ddmultisigaddress

19a354b Output a descriptor in createmultisig and addmultisigaddress (Andrew Chow)

Pull request description:

  Give a descriptor from `createmultisig` and `addmultisigaddress`.

  Extracted from bitcoin#16528 with `addmultisgaddress` and tests added.

ACKs for top commit:
  Sjors:
    tACK 19a354b
  MarcoFalke:
    ACK 19a354b
  promag:
    Code review ACK 19a354b.
  meshcollider:
    utACK 19a354b

Tree-SHA512: e813125fbbc358ea8d45b1748de16a29a94efd83175b748fb8fa3b0bfc8e783ed36b6c554d84f5d4ead1ba252a83a3e937b6c3f75da7b8d3b4e55f94d6013771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.