Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign uprpc: Output a descriptor in createmultisig and addmultisigaddress #18032
+33
−1
Conversation
This comment has been minimized.
This comment has been minimized.
|
Code review ACK, briefly tested. Why didn't we think of this earlier? |
This comment has been minimized.
This comment has been minimized.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
This comment has been minimized.
This comment has been minimized.
|
Also add a mention to doc/descriptors.md? |
This comment has been minimized.
This comment has been minimized.
|
Added a mention in descriptors.md |
This comment has been minimized.
This comment has been minimized.
|
tACK 19a354b |
luke-jr
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Feb 9, 2020
Github-Pull: bitcoin#18032 Rebased-From: 19a354b
|
utACK 19a354b |
MarcoFalke
changed the title
This comment has been minimized.
This comment has been minimized.
|
ACK 19a354b |
MarcoFalke
added a commit
that referenced
this pull request
Feb 9, 2020
…sigaddress 19a354b Output a descriptor in createmultisig and addmultisigaddress (Andrew Chow) Pull request description: Give a descriptor from `createmultisig` and `addmultisigaddress`. Extracted from #16528 with `addmultisgaddress` and tests added. ACKs for top commit: Sjors: tACK 19a354b MarcoFalke: ACK 19a354b promag: Code review ACK 19a354b. meshcollider: utACK 19a354b Tree-SHA512: e813125fbbc358ea8d45b1748de16a29a94efd83175b748fb8fa3b0bfc8e783ed36b6c554d84f5d4ead1ba252a83a3e937b6c3f75da7b8d3b4e55f94d6013771
luke-jr
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Feb 12, 2020
Github-Pull: bitcoin#18032 Rebased-From: 19a354b
sidhujag
added a commit
to syscoin/syscoin
that referenced
this pull request
Feb 18, 2020
…ddmultisigaddress 19a354b Output a descriptor in createmultisig and addmultisigaddress (Andrew Chow) Pull request description: Give a descriptor from `createmultisig` and `addmultisigaddress`. Extracted from bitcoin#16528 with `addmultisgaddress` and tests added. ACKs for top commit: Sjors: tACK 19a354b MarcoFalke: ACK 19a354b promag: Code review ACK 19a354b. meshcollider: utACK 19a354b Tree-SHA512: e813125fbbc358ea8d45b1748de16a29a94efd83175b748fb8fa3b0bfc8e783ed36b6c554d84f5d4ead1ba252a83a3e937b6c3f75da7b8d3b4e55f94d6013771
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
achow101 commentedJan 30, 2020
Give a descriptor from
createmultisigandaddmultisigaddress.Extracted from #16528 with
addmultisgaddressand tests added.