Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Output a descriptor in createmultisig and addmultisigaddress #18032

Merged
merged 1 commit into from Feb 9, 2020

Conversation

achow101
Copy link
Member

@achow101 achow101 commented Jan 30, 2020

Give a descriptor from createmultisig and addmultisigaddress.

Extracted from #16528 with addmultisgaddress and tests added.

@sipa
Copy link
Member

@sipa sipa commented Jan 30, 2020

Code review ACK, briefly tested.

Why didn't we think of this earlier?

@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Jan 30, 2020

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@sipa
Copy link
Member

@sipa sipa commented Jan 31, 2020

Also add a mention to doc/descriptors.md?

@achow101
Copy link
Member Author

@achow101 achow101 commented Jan 31, 2020

Added a mention in descriptors.md

@Sjors
Copy link
Member

@Sjors Sjors commented Jan 31, 2020

tACK 19a354b

Copy link
Member

@promag promag left a comment

Code review ACK 19a354b.

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this issue Feb 9, 2020
Copy link
Contributor

@meshcollider meshcollider left a comment

utACK 19a354b

@MarcoFalke MarcoFalke changed the title Output a descriptor in createmultisig and addmultisigaddress rpc: Output a descriptor in createmultisig and addmultisigaddress Feb 9, 2020
@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Feb 9, 2020

ACK 19a354b

MarcoFalke added a commit that referenced this issue Feb 9, 2020
…sigaddress

19a354b Output a descriptor in createmultisig and addmultisigaddress (Andrew Chow)

Pull request description:

  Give a descriptor from `createmultisig` and `addmultisigaddress`.

  Extracted from #16528 with `addmultisgaddress` and tests added.

ACKs for top commit:
  Sjors:
    tACK 19a354b
  MarcoFalke:
    ACK 19a354b
  promag:
    Code review ACK 19a354b.
  meshcollider:
    utACK 19a354b

Tree-SHA512: e813125fbbc358ea8d45b1748de16a29a94efd83175b748fb8fa3b0bfc8e783ed36b6c554d84f5d4ead1ba252a83a3e937b6c3f75da7b8d3b4e55f94d6013771
@MarcoFalke MarcoFalke merged commit 19a354b into bitcoin:master Feb 9, 2020
2 checks passed
luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this issue Feb 12, 2020
sidhujag pushed a commit to syscoin/syscoin that referenced this issue Feb 18, 2020
…ddmultisigaddress

19a354b Output a descriptor in createmultisig and addmultisigaddress (Andrew Chow)

Pull request description:

  Give a descriptor from `createmultisig` and `addmultisigaddress`.

  Extracted from bitcoin#16528 with `addmultisgaddress` and tests added.

ACKs for top commit:
  Sjors:
    tACK 19a354b
  MarcoFalke:
    ACK 19a354b
  promag:
    Code review ACK 19a354b.
  meshcollider:
    utACK 19a354b

Tree-SHA512: e813125fbbc358ea8d45b1748de16a29a94efd83175b748fb8fa3b0bfc8e783ed36b6c554d84f5d4ead1ba252a83a3e937b6c3f75da7b8d3b4e55f94d6013771
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Oct 26, 2020
Summary: This is a backport of Core [[bitcoin/bitcoin#18032 | PR18032]]

Test Plan:
  ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8116
sidhujag pushed a commit to syscoin-core/syscoin that referenced this issue Nov 10, 2020
…ddmultisigaddress

19a354b Output a descriptor in createmultisig and addmultisigaddress (Andrew Chow)

Pull request description:

  Give a descriptor from `createmultisig` and `addmultisigaddress`.

  Extracted from bitcoin#16528 with `addmultisgaddress` and tests added.

ACKs for top commit:
  Sjors:
    tACK 19a354b
  MarcoFalke:
    ACK 19a354b
  promag:
    Code review ACK 19a354b.
  meshcollider:
    utACK 19a354b

Tree-SHA512: e813125fbbc358ea8d45b1748de16a29a94efd83175b748fb8fa3b0bfc8e783ed36b6c554d84f5d4ead1ba252a83a3e937b6c3f75da7b8d3b4e55f94d6013771
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants