rpc: Output a descriptor in createmultisig and addmultisigaddress #18032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code review ACK, briefly tested. Why didn't we think of this earlier? |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
|
Also add a mention to doc/descriptors.md? |
|
Added a mention in descriptors.md |
|
tACK 19a354b |
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this issue
Feb 9, 2020
Github-Pull: bitcoin#18032 Rebased-From: 19a354b
MarcoFalke
changed the title
|
ACK 19a354b |
MarcoFalke
added a commit
that referenced
this issue
Feb 9, 2020
…sigaddress 19a354b Output a descriptor in createmultisig and addmultisigaddress (Andrew Chow) Pull request description: Give a descriptor from `createmultisig` and `addmultisigaddress`. Extracted from #16528 with `addmultisgaddress` and tests added. ACKs for top commit: Sjors: tACK 19a354b MarcoFalke: ACK 19a354b promag: Code review ACK 19a354b. meshcollider: utACK 19a354b Tree-SHA512: e813125fbbc358ea8d45b1748de16a29a94efd83175b748fb8fa3b0bfc8e783ed36b6c554d84f5d4ead1ba252a83a3e937b6c3f75da7b8d3b4e55f94d6013771
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this issue
Feb 12, 2020
Github-Pull: bitcoin#18032 Rebased-From: 19a354b
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this issue
Feb 18, 2020
…ddmultisigaddress 19a354b Output a descriptor in createmultisig and addmultisigaddress (Andrew Chow) Pull request description: Give a descriptor from `createmultisig` and `addmultisigaddress`. Extracted from bitcoin#16528 with `addmultisgaddress` and tests added. ACKs for top commit: Sjors: tACK 19a354b MarcoFalke: ACK 19a354b promag: Code review ACK 19a354b. meshcollider: utACK 19a354b Tree-SHA512: e813125fbbc358ea8d45b1748de16a29a94efd83175b748fb8fa3b0bfc8e783ed36b6c554d84f5d4ead1ba252a83a3e937b6c3f75da7b8d3b4e55f94d6013771
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this issue
Oct 26, 2020
Summary: This is a backport of Core [[bitcoin/bitcoin#18032 | PR18032]] Test Plan: ninja all check-all Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D8116
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this issue
Nov 10, 2020
…ddmultisigaddress 19a354b Output a descriptor in createmultisig and addmultisigaddress (Andrew Chow) Pull request description: Give a descriptor from `createmultisig` and `addmultisigaddress`. Extracted from bitcoin#16528 with `addmultisgaddress` and tests added. ACKs for top commit: Sjors: tACK 19a354b MarcoFalke: ACK 19a354b promag: Code review ACK 19a354b. meshcollider: utACK 19a354b Tree-SHA512: e813125fbbc358ea8d45b1748de16a29a94efd83175b748fb8fa3b0bfc8e783ed36b6c554d84f5d4ead1ba252a83a3e937b6c3f75da7b8d3b4e55f94d6013771
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Give a descriptor from
createmultisigandaddmultisigaddress.Extracted from #16528 with
addmultisgaddressand tests added.