Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
net: Add NAT-PMP port forwarding support #18077
To compile with NAT-PMP support on Ubuntu
Some follow-ups are out of this PR's scope:
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Concept ACK. Lightly tested configure / build on macOS.
Unfortunately I'm behind a IPv6 DS-Lite router, I can't test the IPv4 port forward. Perhaps
I looked up the error code, and it's what I would expect given my setup:
Two suggesitons for followups, or this PR:
Thank you for your review and testing.
In followups every library call (
Agree. From the OP: