-
Notifications
You must be signed in to change notification settings - Fork 36.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: GUI: Remove broken ability to edit the address field in the sending address book #18194
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
can you give a "tutorial" on how to change address on master? I can't seem to figure this out. |
@instagibbs : Click "sending addresses" and then right click on an address and then "edit". Same on master: |
The edit function is already somehow hidden. IMO Having a "address books" without an edit function seems quite limiting. @luke-jr: what would it mean to fix bug1/2? Would deprecating the address book (then removing it at some point) make sense? |
How would you edit labels then? |
@MarcoFalke Actually, this was only addressing inline editing, so the dialog is another place to disable the editing... Fixed |
@instagibbs I suspect "how to inline edit" is platform-dependent, but on my KDE-based system, double-clicking on the field I intend to edit does it. |
NACK sorry. |
@emilengler What is the use case? Clearly nobody uses it since it doesn't work. @jonasschnelli seems confused about the PR, and isn't NACKing it... |
@luke-jr Do you really know that nobody is using it? |
It doesn't work at all... And hasn't for a long time now. How could anyone be using it? |
That's why I said improve it instead of remove it
You're right on that point though but maybe some users are frustrated because it didn't worked |
This has been broken since 0.17 and nobody noticed, so just remove it entirely. Bug 1 (since 0.17, bitcoin#10244): Instead of moving the label, the new address's label was set to the new address itself, and the actual label was lost completely. Bug 2 (since 0.19, bitcoin#13756): "used" DestData should have been retained at the old address rather than deleted entirely. This commit just disables the Qt::ItemIsEditable flag, which should be the minimal needed to disable the functionality and therefore the bugs. Github-Pull: bitcoin#18194 Rebased-From: 5e82176
…SendingAddress Github-Pull: bitcoin#18194 Rebased-From: 2667478
FWIW I tend to edit labels by right-clicking on a transaction then doing 'edit label'. Haven't used the address book for ages. But as long as it's there it should probably work. |
This has no impact whatsoever on the ability to edit labels anywhere. This is about when the user attempts to edit the address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach ACK 2667478, tested on Linux Mint 19.3.
Some notes:
-
could the last commit "GUI: Disallow editing the address in EditAddressDialog with mode=EditSendingAddress" be squashed into the first one "Bugfix: GUI: Disable inline editing of sending addresses"
-
the tooltip content is misleading now: "Right click to edit address or label".
This has been broken since 0.17 and nobody noticed, so just remove it entirely. Bug 1 (since 0.17, bitcoin#10244): Instead of moving the label, the new address's label was set to the new address itself, and the actual label was lost completely. Bug 2 (since 0.19, bitcoin#13756): "used" DestData should have been retained at the old address rather than deleted entirely. Bug 3: Editing both the label and address in the label-editing dialog would still delete the label for the old address. This commit just turns off the GUI editing capabilities, which should be the minimal needed to disable the functionality and therefore the bugs.
2667478
to
0a44e08
Compare
Squashed & fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 0a44e08
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
If this is still relevant, it should be rebased and then re-opened in the gui repo. |
Closing per #18194 (comment). |
Apparently in the sending address book, it is possible to edit the address field of an address/label row.
Doing so, however, has 2 pretty big bugs:
Bug 1 (since 0.17, #10244): Instead of moving the label, the new address's label was set to the new address itself, and the actual label was lost completely.
Bug 2 (effectively since 0.19, #13756): All metadata associated with the old address (prior to edit) is deleted, except for label and purpose. Probably some should remain with the old address (eg, whether the associated key was used to spend already), and others should be moved to the new address (no existing cases, just hypothetically). I doubt we should ever just outright delete it.
Edit: Bug 3 (unconfirmed, debatable): Editing both the label and address in the label-editing dialog would still delete the label for the old address.
Proposed resolution: Remove the ability to edit the address field. It doesn't really make sense.