Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI Support. Mostly written by Luke-Jr. #182

Closed
wants to merge 1 commit into from

Conversation

TheBlueMatt
Copy link
Contributor

This change supports bitcoin: URIs in bitcoin. It is being resubmitted due to git repo issues on my end (yet again). Sorry about that.

Forums thread here: https://www.bitcoin.org/smf/index.php?topic=6205.0

@gavinandresen
Copy link
Contributor

Does this work "out-of-the-box" on Windows/Mac/Linux in Firefox/Chrome and Safari(mac) and IE(windows) ?

Does it do something reasonable if you click on a bitcoin URI if you don't happen to have bitcoin running?

And is there a solution for bitcoin URIs that works if you use an online wallet service?

@TheBlueMatt
Copy link
Contributor Author

Windows? yes, should work in any app which uses Window's native uri mapping, that means safari (win) IE, Firefox, etc, etc, etc.
Linux? That is always done at the packaging level. For this to work, Bitcoin has to be packaged for the distro (as URI mapping depends on the distro). If wx2.8 gets merged, Bitcoin-wx will be in the Debian repos pretty quick, and Ubuntu not long after. I've been thinking about putting up a personal package archive on launchpad for older versions of Ubuntu/Debian (as bitcoin-wx/bitcoind will only be packaged officially in the next Ubuntu release, and only in stable in the next Debian release).
Mac? That is a bit tougher. AFAICT, mac URI/URL registering requires the use of special APIs that are Mac-native. As I dont have a Bitcoin build-environment setup on a mac, I can't really spend much time experimenting with it (I may have not done enough research and there is a way to handle URI calls the same way every other OS does, ie 2nd parameter to Bitcoin is the URI/L, but maybe a Mac developer can comment here).

Bitcoin already running? Yep, if bitcoin is already running it will send the send message to the send queue of the existing Bitcoin, otherwise it will open Bitcoin and load the send dialog as soon as Bitcoin is initialized.

Online wallet services? That one is a bit trickier. I know the existing chrome RPC plugin accepts bitcoin: URIs, but plugins are the wrong way to do that here. If a web site wants to register a URI on most OSes, it has to have some native client of some kind in the OS. If a web-wallet services has that, they need only register bitcoin: URIs and then let the system decide which to use (Windows + Ubuntu both have a control panel thing to let the user control this, Id assume other OSs/distros as well)

@TheBlueMatt
Copy link
Contributor Author

I did a bit more research on doing URIs in OSX as I would like to see this merged some time and there is no way to handle URI/Ls in OSX except by using their native APIs (they dont just pass the URL as a parameter like every other OS) or some kind of wrapper script which handles URIs and opens Bitcoin. As both of those are both terrible solutions, I dont think it is a good idea to bother with URI/L support on OSX until someone does a native UI for OSX.

@TheBlueMatt
Copy link
Contributor Author

Implemented in bitcoin-qt

@TheBlueMatt TheBlueMatt closed this Oct 4, 2011
deadalnix pushed a commit to deadalnix/bitcoin that referenced this pull request Dec 13, 2016
Fix LargestBlockSeen to update properly in a lockless but atomic manner.
classesjack pushed a commit to classesjack/bitcoin that referenced this pull request Jan 2, 2018
Restore header parameters to Bitcoin values (these didn't do what I expected)
cryptapus added a commit to cryptapus/bitcoin that referenced this pull request Feb 28, 2020
Revert "rpc/gui: Remove 'Unknown block versions being mined' warning"
rajarshimaitra pushed a commit to rajarshimaitra/bitcoin that referenced this pull request Aug 5, 2021
- as before "2-out-of-2" is more appropriate than "2-2" 
- "thus" is not what you wanted to express, "however" is what you wanted to say
- added missing comma
- etc
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants