Sebible v0.18.1 prow #18200
Closed
Sebible v0.18.1 prow #18200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update version after branching off Tree-SHA512: 48f2c2ecfc485f0c864d2b1748ffb382df444abdc8387886bee1be5e49bbcaa6baf0a52544abb7189d762a3f33c82a794413511580e6154c0f82e5e58bea0b0f
- Merge release notes fragments into release-notes.md - Remove downgrading notes (as I understand this pertains to `<0.15`, this doesn't warrant mentioning anymore) Tree-SHA512: 839e30807651ff53efa713f707ba0744c6c6c9bcb2c9c8afc0e299c93f772cc9a0ef294ba7e15f7049280556404d9b2e96b74f28e456aa36130af05bc7cfe035
…ions fa3148a doc: Remove ppa from linux build instructions (MarcoFalke) Pull request description: Same commit hash as bitcoin#15518 Tree-SHA512: b6ab2f84ca8efc4e71604422b427793b8b17d8d50422177f4ce967421457eee8c2f1d1e0e4fa8cad05cf42ab4343a25e4ee0404cafee978456eefe0c72b11f2b
Tree-SHA512: 26bd0cce9eaf906a921defd7e4abdbf1056f29c6327950d766753149dde19d6af39ee827f6e02ebfede488f5afb6b4048814061c45e611ffa43f8ef4598edcdb
Github-Pull: bitcoin#15527 Rebased-From: fad76e7 Tree-SHA512: 15b8af83029b095fbe9f7163e2b82247f590831165596b67ed9acae8c11715593c57702731cfe3320e3fa645137fd90314598d1bf91e81cea01889ecc6d05d3a
519b0bc Make last disconnected block BLOCK_FAILED_VALID, even when aborted (Pieter Wuille) 8d22041 Optimization: don't add txn back to mempool after 10 invalidates (Pieter Wuille) 9ce9c37 Prevent callback overruns in InvalidateBlock and RewindBlockIndex (Pieter Wuille) 9bb32eb Release cs_main during InvalidateBlock iterations (Pieter Wuille) 9b1ff5c Call InvalidateBlock without cs_main held (Pieter Wuille) 241b2c7 Make RewindBlockIndex interruptible (Pieter Wuille) 880ce7d Call RewindBlockIndex without cs_main held (Pieter Wuille) 436f7d7 Release cs_main during RewindBlockIndex operation (Pieter Wuille) 1d34287 Merge the disconnection and erasing loops in RewindBlockIndex (Pieter Wuille) 32b2696 Move erasure of non-active blocks to a separate loop in RewindBlockIndex (Pieter Wuille) 9d6dcc5 Abstract EraseBlockData out of RewindBlockIndex (Pieter Wuille) Pull request description: Same repo and branch like "Granular invalidateblock and RewindBlockIndex bitcoin#15402 ", can be merged as is. This saves us all the cherry-picks and review of the backport cherry-picks. Tree-SHA512: 20c27c5f807c3d85e0072f9e2cdefad4ad7d329d6b26658a00844d5fcf0ed729059daf765e04e6382db2b5915117b15949cd4989d864917ab105c92e2e5e9986
Github-Pull: bitcoin#15549 Rebased-From: 32da92b Tree-SHA512: c79455ed3aa0e529821ed30c5d36244dcc9fbf9154b63dfcce4789143d8a737f83ea2aaea8993748babc4cec45ae0e88449d2a6ddc90dcf62a39cf8d6a2ace2e
Github-Pull: bitcoin#15486 Rebased-From: 4d83401 Tree-SHA512: c7843191c470d8b3298d4375632ddbcfd26358d21100bcbffa8d40498782f9dfef08cfb7b3c040525ef912b27ddd593322b60f8f21e16e2ae9bae66433ce807e
Fixes a bug where feelers could be stuck trying to resolve a collision in the tried table that is to an address in the same netgroup as an existing outbound peer. Thanks to Muoi Tran for the original bug report and detailed debug logs to track this down. Github-Pull: bitcoin#15486 Rebased-From: 4991e3c Tree-SHA512: 2752c9909d55ff63b9143168033d0d3952effba7f911181919eb62291edf822ec54fffbb20e35b5c5f8cb1092d75c496665da00139dbebe5ce402cbea3ad87c5
After 40 minutes, time out a test-before-evict entry and just evict without testing. Otherwise, if we were unable to test an entry for some reason, we might break using feelers altogether. Github-Pull: bitcoin#15486 Rebased-From: f71fdda Tree-SHA512: 66c61a9f030b1666e98e4fe66dd6cfc5f1d03b2a1ec01567b195903db6e4412ac778f4464ee9ef35ae6faa1ab7e4b18ef7ecb9a7ced29e6494046990aebf7b76
Github-Pull: bitcoin#15486 Rebased-From: 20e6ea2 Tree-SHA512: 73b37a98cf4d9ede1d39c30d178d63a5a6865dba6cb7a9f33bd1e03445acb708b3007c7cde991b5de96a407262adda23279fe7a1d2ed31b0b5a33b2e97aaba9b
Tree-SHA512: a2c5818dd2fa261b86a177e846e5a58062f1ea3adf3d4fef5ac6f4a503e7f9f143189a0068847f405cc68f9900f983db5c3ab9799a4e29dd41ced09542f57175
Github-Pull: bitcoin#15548 Rebased-From: fa55104 Tree-SHA512: 195d9d459431ae879a27e26d01962f020ddbbf648da26e52121c4fa7eb3438330f1ce34de431757e5079bf248f7129539e1d1a83c9c795ab57dc8c51545384bb
Github-Pull: bitcoin#15559 Rebased-From: a4d0fd0 Tree-SHA512: 43f985ccb1af22e416230b8f351396d1fa677ee4e60f6952962ed37e842f5746df8a58ae7c35d6a7518af4b5974ee753b17ec3578394122584ca10e9ed561268
Github-Pull: bitcoin#15559 Rebased-From: 335931d Tree-SHA512: ebe460e935e33fbbbe725db403654ee65c86a606401e8519e1180551e2ccd43661eb4ad20bf065f2c0c2a8026c3bb3bce796789f8d612e9e197ceb8d541a63a9
Github-Pull: bitcoin#15582 Rebased-From: c9963ae Tree-SHA512: ed1dcfafb7015de5405112938b04c4009bec3349a8d4e8aca641598ccab31a34c7f16b5045670909fd2e795fc40640a79658ef6b1771e9f21abd0ca759b239b5
Tree-SHA512: a494a9039555b24a7a4f4ecebc2a1b7c47bf8937b2ec583659e4443b49919e6ddd0e276c273ce2f89955f433de300ea0c36216e288309a7fac5b2e3d2534a604
Github-Pull: bitcoin#15583 Rebased-From: 15c69b1 Tree-SHA512: edef7cafc5a2cb8d3355591a7742ef61454a5dedbb1dc22f6cc6bae42329d887f3f4a054f2aeedf31180051f50b6478d09e204066205699dabc0cb67b0ce4a96
Tree-SHA512: 8ce284bd20cfeee8bfb9f7144c9a4239b460f83ac18df840b417b43b11e8028b649fb056c9266d01ac39a926a8f4e931d0dc3ee302d0c84f5fcb2c7d18126322
Tree-SHA512: 97a6d7193da6f9d84e35e2511d949b08be990e035ffb38a149bf45df085ea41f4c84953ddd7a38b0165574f7168419fc2bd3ad6351f5012d89cf884d055693e7
a756363 [docs] document BIP 61 deprecation (John Newbery) da14d90 [p2p] Enable BIP 61 REJECT messages by default (John Newbery) Pull request description: This PR reverts bitcoin#14054 following discussion on the bitcoin-dev mailing list. It also adds release notes to clearly document that the `enablebip61` option will be disabled by default in a future release before being removed entirely. Tree-SHA512: 0c9162045a4fb95689a0cb2de19f98a83636c9a6fb7ffa6809773b593c6c00b14e0480683e4d1c48e9b7f90e89cf7c2dca18bff42f5d2da2a43c522039e9f1ee
Github-Pull: bitcoin#15617 Rebased-From: 054d01d Tree-SHA512: 2c47cf823cc51aee5a224513a0ca2fd1132f4c567d255ead661e88f009dc5d1db73da79b5e65a63b11b222e17292fdff9035a93cb2e53215d9bbb21a5bce7a41
…eAndDeleteWallet when no modal widget is active 98a24a2 gui: Defer removeAndDeleteWallet when no modal widget is active (João Barbosa) Pull request description: 0.18 Backport of bitcoin#15614 Tree-SHA512: 8f785705325364ecfa37045090f10ca615f457e279789b0ce0d61f2667f491bce9b44f5e5cdeeecf63d61356213d9a97a3578841295cc8480cf42e037c2decb2
This functionality was removed in v0.18.
…om validateaddress help be8b9c6 [rpc] Remove deprecated functionality message from validateaddress help (John Newbery) Pull request description: This functionality was removed in v0.18. ACKs for commit be8b9c: MarcoFalke: utACK be8b9c6 fanquake: utACK be8b9c6 Tree-SHA512: 7e30f1e56020aa3a59e736574075191155866788156d0d30eaf963c0a5015ad0de43787c6b73a765319f2dccec0117a2230a312d18ca3f9be3986ce3de4afdb3
Tree-SHA512: 52b66903e169fc3f53f8e4eccb0f765df9a6fbc149ba98fbe7f8b8e7f03e8196ebef8c19ed7412f6d09ddfa4b82e38aa357e1fca6942b0d1d7fe89ea66053556
Tree-SHA512: 0d7a73946d75ac79df65dc6fb5c885353729a3401d985e2d452bf9e5964be7e169ae2cab481cba5307f5d3480d307e1c9e198090f2ede2c9c020543947d44db4
The menu must be created before connecting to aboutToShow signal. Github-Pull: bitcoin#16231 Rebased-From: 5224be5
Qt docs: This attribute must be set before QGuiApplication is constructed. Github-Pull: bitcoin#16254 Rebased-From: 099e4b9
Github-Pull: bitcoin#15826 Rebased-From: b679785
See also: dddd1d0
bcb27d7 .python-version: Bump to 3.5.6 (MarcoFalke) af25a75 Add comments to Python ECDSA implementation (John Newbery) 715da91 Set AA_EnableHighDpiScaling attribute early (Hennadii Stepanov) 2800b3d gui: Fix open wallet menu initialization order (João Barbosa) e78007f Make and get the multisig redeemscript and destination in one function instead of two (Andrew Chow) d9fc969 Pure python EC (Pieter Wuille) 23ba460 test: Add test that addmultisigaddress fails for watchonly addresses (MarcoFalke) 13b3bb5 test: Fixup creatmultisig documentation and whitespace (MarcoFalke) 79745d1 Replace remaining fprintf with tfm::format manually (MarcoFalke) beb09f0 scripted-diff: Replace fprintf with tfm::format (MarcoFalke) e29aa6e Exceptions should be caught by reference, not by value. (Kristaps Kaupe) f88959b tinyformat: Add doc to Bitcoin Core specific strprintf (MarcoFalke) 0023c97 rpc: bugfix: Properly use iswitness in converttopsbt (MarcoFalke) 832eb4f Bugfix: test/functional/rpc_psbt: Correct test description comment (Luke Dashjr) 966d8d0 Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions (Luke Dashjr) bb36ac8 rpc: Switch touched RPCs to IsValidNumArgs (MarcoFalke) d24d0ec Add example 2nd arg to signrawtransactionwithkey (Chris Moore) 592016b fixup: Fix prunning test (João Barbosa) c80a498 Fix RPC/pruneblockchain returned prune height (Jonas Schnelli) b239824 gui: Enable open wallet menu on setWalletController (João Barbosa) d1f2611 Add test for GCC bug 90348 (Pieter Wuille) d80c558 gui: Set progressDialog to nullptr (João Barbosa) 7ed1a60 gui: Enable console line edit on setClientModel (João Barbosa) b55cbe8 qt: fix opening bitcoin.conf via Preferences on macOS; see bitcoin#15409 (shannon1916) b6c1f94 Disallow extended encoding for non-witness transactions (take 3) (MarcoFalke) 8603108 Add test for superfluous witness record in deserialization (Gregory Sanders) 5a58ddb Fix missing input template by making minimal tx (Gregory Sanders) 206f5ee Disallow extended encoding for non-witness transactions (Pieter Wuille) 3dbc7de Show loaded wallets as disabled in open menu instead of nothing (MeshCollider) a635377 Install bitcoin-wallet manpage. (Daniel Kraft) eb85ee6 Doc: remove text about txes always relayed from -whitelist (David A. Harding) 890a92e doc: Mention blocksonly in reduce-traffic.md, unhide option (MarcoFalke) 3460555 test: Add test for p2p_blocksonly (MarcoFalke) 8f215c7 test: Format predicate source as multiline on error (MarcoFalke) 9c1a607 net: Rename ::fRelayTxes to ::g_relay_txes (MarcoFalke) 5935f01 build with -fstack-reuse=none (MarcoFalke) Pull request description: Tree-SHA512: 5cd73a4319cb69c92b528239cf97c0ed5fcf2b9e8c7fe154e4679eeec95db433a0223d8dc574e4cdc96c1913cfdf160b10c42dcdbcb5bbc8fb743c07930ef9da
…nessScript param Github-Pull: bitcoin#16250 Rebased-From: 0117459
…cript/witnessScript 1dc357d signrawtransactionwithkey: report error when missing redeemScript/witnessScript param (Anthony Towns) Pull request description: Backport of bitcoin#16250 which fixes regression introduced in 0.18 in relation to signrawtransactionwithkey error handling (see bitcoin#16249). Tree-SHA512: 0d75fa2aa578b886ace3bda92a02e25993f9f51d41db8c0eb3013bd77d266c45ad8b67dd0ed11c66533724f892be4e254edeb59fa70585ff762f522791fcca36
Github-Pull: bitcoin#16348 Rebased-From: f27bd96
Github-Pull: bitcoin#16348 Rebased-From: 64fee48
…thod result" df695db qt: Assert QMetaObject::invokeMethod result (João Barbosa) e2f7677 gui: Fix missing qRegisterMetaType(WalletModel*) (João Barbosa) Pull request description: ACKs for top commit: hebasto: ACK df695db, I have not tested the code, but I have reviewed it and it looks OK, I agree it can be merged. laanwj: ACK df695db Tree-SHA512: 5ce162e59331f6da8ae9ba41eff809881442fab93d65362b5f67aba19da76a72362f0daba9ad1f909478bf26f2daf53b110a0486d7b29b23b3716a7cd7177922
Github-Pull: bitcoin#16405 Rebased-From: a981e74
…he event's callback b2711b9 fix: tor: Call event_base_loopbreak from the event's callback (João Barbosa) Pull request description: Github-Pull: bitcoin#16405 Rebased-From: a981e74 ACKs for top commit: laanwj: ACK b2711b9, code change is the same as for master fanquake: ACK b2711b9 Tree-SHA512: 9f225e505c0241be422ed897f56aef6ebad57e15d3bfe5154c7fe4f874df342e0df287871cd737eb777d0f45865a6d129cd5d1a4c036ea0a4e5d4f36520ab174
poll should block until there is data to be read or the timeout expires. Filtering for the POLLOUT event causes poll to return immediately which leads to high CPU usage when trying to connect to non-responding peers through tor. Removing POLLOUT matches how select is used when USE_POLL isn't defined. Github-Pull: bitcoin#16412 Rebased-From: a52818c Tree-SHA512: eaf466630ba9d2a2a7443c9679c83c2cb13e779a5948f409cddb4c48cf32126ac68f3de48e394f9302e99858efa17cdb14650751a1b55c3b79e8a7507cab352d
Tree-SHA512: b97fd91b7ab1eb2297007a9821def31c065a2a33f12cf51fd5e5be5dff1e8afb4f5b001d220c3873d72ca5b06484ad2d1e2c8df5300770145de0dfebe56db303
Tree-SHA512: f746d4cfda1eb433c4c99b8d80392ac2e905c1f39591eb5579a708129e3b1b36479a2da45221594713cf20069bde78c29a31cb10d39c7bc96544694d9832cda0
Tree-SHA512: 805a6931e2bd059ee2da42634f687828a50b2ccd3a1ac0071cd626e9a2f52b7afc79af3c8f3d5b013a853d5e59068314e744a4694dceef598710f0694babbd99
Tree-SHA512: e5422eaed5339327b600bfe07e5cdb1517bf6f3d9a39d27c9c59a68ceadbef398960c69630bc727f3f8d7330353e7823905f5107dba6d8827965565157cdeca1
…md and riscv changes 5f5b444 Doc: remove old release notes about systemd and riscv changes (David A. Harding) Pull request description: Removes these two paragraphs that were part of the 0.18.0 release notes but which I don't think need to be repeated for the 0.18.1 release notes. The systemd release note in particular links to a section that isn't part of the document. ACKs for top commit: practicalswift: ACK 5f5b444 laanwj: ACK 5f5b444 fanquake: ACK 5f5b444 - this should be fine. Tree-SHA512: 3930b832eeed1f938cd6423dd9ac1e02ab7bb4fc218f433551fa995f40b84e8f2af5755ca4bf56caccdc742b6884bc79b381c9bdb3ad90e99ca90011d9e12665
Tree-SHA512: b74ff824278e6a4c4781c904e3f68295c76d9de79cc174a6e7127273295ef3fddb87de89143ceb76805e33b8c2dec77b3e6ae4bec97a3128d9908c065c7f95de
No changes, only the month changed from July to August. Tree-SHA512: c8f672f3a6e570ea1feda2c2f17d30da8a04b705d990bf5aec8e09da5937f3f9a608f4f50941f183c536a4158001b13d149bd0c873a24eae48ae57d96cd274c8
|
/test pull-bitcoind-image-build-image |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.