gui: display mapped AS in peers info window - #18402
Conversation
|
Concept ACK. Smth similar was in my task list ;) |
|
A good addition! |
promag
left a comment
promag
left a comment
There was a problem hiding this comment.
Concept ACK, honestly you could squash these commits.
8580db1 to
64f3838
Compare
hebasto
left a comment
hebasto
left a comment
There was a problem hiding this comment.
promag
left a comment
promag
left a comment
There was a problem hiding this comment.
Code review ACK modulo suggestion.
Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
64f3838 to
76db4b2
Compare
|
ACK 76db4b2 |
|
I wonder if the string "Mapped AS" displayed in the GUI could be worded in other ways? Like "BGP AS number", so that it could be more self-explanatory, or at least more google-able? |
|
@andronoob there is an explanatory tooltip -- "The mapped Autonomous System used for diversifying peer selection." -- see https://github.com/bitcoin/bitcoin/pull/18402/files#diff-2537e9bcbac21d35d8fa28ce1a35e89dR1508. In RPC |
To my understanding, such phrase means: "(Such number is) The Autonomous System (AS) (number, aka ASN) which this peer is mapped to (according to the map data). BGP AS is considered during peer selection, in order to diversify connected peers. (thus some risks related might be mitigated)" Correct me if I'm wrong? |
| </item> | ||
| <item> | ||
| <widget class="QLineEdit" name="lineEdit"> | ||
| <property name="placeholderText"> |
There was a problem hiding this comment.
I guess the property order change has been done through QTCreator? I would have probably unstaged those.
jonasschnelli
left a comment
jonasschnelli
left a comment
There was a problem hiding this comment.
Core Review ACK 76db4b2
Summary: > Continuing the asmap integration of [[bitcoin/bitcoin#16702 | PR16702]] which added mapped_as to the rpc getpeerinfo output, this adds the mapped AS to the Peers detail window in the GUI wallet. > Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> This is a backport of Core [[bitcoin/bitcoin#18402 | PR18402]] Test Plan: `ninja && src/qt/bitcoin-qt` Menu `Window -> Peers`, select a peer, the "Mapped AS" field is now visible at the bottom of the right widget. Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D8876
7 participants
Continuing the asmap integration of #16702 which added
mapped_asto the rpc getpeerinfo output, this adds the mapped AS to the Peers detail window in the GUI wallet.$ src/qt/bitcoin-qt -asmap=<path-to-asmap-file>(asmap on)$ src/qt/bitcoin-qt(asmap off)Added a tooltip and a couple of minor fixups.