test: Remove unsafe BOOST_TEST_MESSAGE #18472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mzumsande |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
maflcko
force-pushed
the
2003-testNoBoost
branch
from
fa93702
to
fa3cc0b
Compare
|
tested ACK fa3cc0b Thank you! |
|
Tested ACK fa3cc0b Maybe test/README.md could mention the DEBUG_LOG_OUT option which I find really helpful, and possibly also a warning that BOOST_TEST_MESSAGE, which is mentioned there, is not threadsafe. |
|
Thanks, I am going to go ahead and merge this bug fix. Will update the docs in a new commit. |
|
Done here: #18486 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 31, 2020
fa3cc0b test: Remove unsafe BOOST_TEST_MESSAGE (MarcoFalke) Pull request description: Fixes bitcoin#17987 Can be tested with ``` ./src/test/test_bitcoin -l test_suite -- DEBUG_LOG_OUT ACKs for top commit: fjahr: tested ACK fa3cc0b mzumsande: Tested ACK fa3cc0b Tree-SHA512: f63b110d77882cd7c0d7574ff6c9c948db8febb3400ecdac45164746b587b0fa223463041801271b3959267ddc1d9a4a67ba76939e242e7dd2f92a2834a400a0
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Apr 1, 2020
7777703 doc: Explain new test logging (MarcoFalke) Pull request description: Explain logging added in bitcoin#18472 and bitcoin#16975 ACKs for top commit: jonatack: ACK 7777703 Tree-SHA512: 3a0aa7bab32a6753d8894d29cf82604b044b23e512102dd275b717eefda3c2212dbf43ea7e9155267350dd9f3bc5badba2eb660152db3efeab30a04f52126c95
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17987
Can be tested with