New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add big endian native s390x build #18569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like going back to using the travis environment, which is in constant flux and thus more brittle. Also, as they replace vanilla packages with their own versions (pyenv etc), debugging failures locally is probably going to be a pain.
But if this runs without much hassle, why not.
.travis.yml
Outdated
cache: | ||
directories: | ||
- $TRAVIS_BUILD_DIR/ci/scratch/.ccache | ||
- $TRAVIS_BUILD_DIR/releases/$HOST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the overwrite needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To get rid of smth like this:
adding /usr/local/Homebrew to cache
creating directory /usr/local/Homebrew
mkdir: cannot create directory ‘/usr/local/Homebrew’: Permission denied
/usr/local/Homebrew is not yet cached
/usr/local/Homebrew: No such file or directory
/usr/local/Homebrew: unknown file type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, I'd rather move the overwrite to macos, since that is causing the trouble
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
ci/test/00_setup_env_s390x_host.sh
Outdated
export LC_ALL=C.UTF-8 | ||
|
||
export HOST=s390x-linux-gnu | ||
export RUN_CI_ON_HOST=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a dangerous setting. Would be best to put this in the .travis.yml to make sure no one is setting this locally and trashing their machine?
Edit: The setting should probably be renamed to DANGER_RUN_CI_ON_HOST or so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The setting should probably be renamed to DANGER_RUN_CI_ON_HOST or so
Implemented.
42b45d0
to
8d4ff5c
Compare
.travis.yml
Outdated
- $TRAVIS_BUILD_DIR/ci/scratch/.ccache | ||
- $TRAVIS_BUILD_DIR/releases/$HOST | ||
- $HOME/Library/Caches/Homebrew | ||
- /usr/local/Homebrew |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this build cross compilation? I think this whole hunk can be discarded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
8d4ff5c
to
6136a96
Compare
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
ACK 6136a96 |
Unlike the Docker wrapped solution (#17591) this PR suggests running on host system directly.
This approach makes builds quick and stable (see: #18106).
The excerpt from the Travis log: