Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Only use git for build info if the repository is actually the right one #18902

Closed
wants to merge 4 commits into from

Conversation

luke-jr
Copy link
Member

@luke-jr luke-jr commented May 7, 2020

Fixes using unrelated git repos again, after the fix in #7522 was unexplicably removed by #18556

Also (really) fixes the "build version hack" (#18349) by embedding the correct tag in the release genbuild.sh

Based on top of #18818 to avoid unnecessary conflicts/rebasing once that's merged

@DrahtBot
Copy link
Contributor

DrahtBot commented May 7, 2020

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request May 7, 2020
… right one

Original-Github-Pull: bitcoin#7522
Rebased-From: e98e3dd e98e3dd

Github-Pull: bitcoin#18902
Rebased-From: d9505bb
luke-jr added a commit to luke-jr/bitcoin that referenced this pull request May 7, 2020
luke-jr added a commit to luke-jr/bitcoin that referenced this pull request May 7, 2020
… right one

Original-Github-Pull: bitcoin#7522
Rebased-From: e98e3dd e98e3dd

Github-Pull: bitcoin#18902
Rebased-From: d9505bb
luke-jr added a commit to luke-jr/bitcoin that referenced this pull request May 7, 2020
luke-jr added a commit to luke-jr/bitcoin that referenced this pull request May 14, 2020
… right one

Original-Github-Pull: bitcoin#7522
Rebased-From: e98e3dd e98e3dd

Github-Pull: bitcoin#18902
Rebased-From: d9505bb
luke-jr added a commit to luke-jr/bitcoin that referenced this pull request May 14, 2020
@bitcoin bitcoin deleted a comment from DrahtBot Nov 9, 2020
@bitcoin bitcoin deleted a comment from DrahtBot Nov 9, 2020
@DrahtBot
Copy link
Contributor

DrahtBot commented Feb 8, 2021

🐙 This pull request conflicts with the target branch and needs rebase.

Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

@MarcoFalke
Copy link
Member

MarcoFalke commented Oct 22, 2021

Closing for now. This needs rebase and there hasn't been any activity for months.

You can leave a comment if you want this to be reopened. (Or create a new pull, since there haven't been any comments here). Though, please make sure the code is passing tests and is ready for review.

@MarcoFalke MarcoFalke closed this Oct 22, 2021
@bitcoin bitcoin locked and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants