Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: tsan on clang-9 #19008

Merged
merged 2 commits into from May 19, 2020
Merged

ci: tsan on clang-9 #19008

merged 2 commits into from May 19, 2020

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented May 18, 2020

Bump the compiler runtime library that includes the sanitizers from clang-8 to clang-9 to get a more recent version. Also, bump the system packages from xenial to bionic to test packages closer to what is commonly used in production.

The second commit is needed to install the tzdata package, which is missing on some operating systems. See https://travis-ci.org/github/MarcoFalke/bitcoin-core/jobs/688455828#L1727

@maflcko maflcko force-pushed the 2005-ciTsanFocal branch 2 times, most recently from fa1b698 to fa92d45 Compare May 18, 2020 18:02
@DrahtBot DrahtBot added the Tests label May 18, 2020
@practicalswift
Copy link
Contributor

Concept ACK

@hebasto
Copy link
Member

hebasto commented May 18, 2020

Concept ACK.

@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@maflcko maflcko changed the title ci: tsan on focal ci: tsan on clang-9 May 19, 2020
MarcoFalke added 2 commits May 18, 2020 20:38
Also fix travis environment variables for this build

Previously the resulting env was:

FILE_ENV="./ci/test/00_setup_env_native_tsan.sh" TEST_RUNNER_EXTRA="--exclude feature_block" #= Not= enough= memory= on= travis= machines=
@maflcko
Copy link
Member Author

maflcko commented May 19, 2020

Shifted goalpost for now

@practicalswift
Copy link
Contributor

ACK faf5521 -- patch looks correct and Travis is happy

Thanks for doing this!

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK faf5521

Maybe it is time to put bionic here:

dist: xenial

?

@fanquake fanquake merged commit e773685 into bitcoin:master May 19, 2020
@maflcko maflcko deleted the 2005-ciTsanFocal branch May 19, 2020 10:30
luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Jun 14, 2020
Also fix travis environment variables for this build

Previously the resulting env was:

FILE_ENV="./ci/test/00_setup_env_native_tsan.sh" TEST_RUNNER_EXTRA="--exclude feature_block" #= Not= enough= memory= on= travis= machines=

Github-Pull: bitcoin#19008
Rebased-From: faf5521
luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Jun 15, 2020
Also fix travis environment variables for this build

Previously the resulting env was:

FILE_ENV="./ci/test/00_setup_env_native_tsan.sh" TEST_RUNNER_EXTRA="--exclude feature_block" #= Not= enough= memory= on= travis= machines=

Github-Pull: bitcoin#19008
Rebased-From: faf5521
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants