cli, test, doc: bitcoin-cli -getinfo multiwallet balances follow-ups

[jonatack]

These are follow-ups to #18594:

• release note for -getinfo multiwallet balances

• update the -getinfo help:

$ bitcoin-cli -h | grep -A3 getinfo
  -getinfo
       Get general information from the remote server, including the balances
       of each loaded wallet when in multiwallet mode. Note that
       -getinfo is the combined result of several RPCs (getnetworkinfo,
       getblockchaininfo, getwalletinfo, getbalances, and in multiwallet
       mode, listwallets), each with potentially different state.

• more robust bitcoin-cli -getinfo command parsing per review feedback in cli: display multiwallet balances in -getinfo #18594 (comment) and regression test coverage for that change

• add assert_scale to test_framework/util.py and improve the coverage in interface_bitcoin_cli.py

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• cli: display multiwallet total balance in -getinfo #19092 (cli: display multiwallet total balance in -getinfo by jonatack)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[hebasto]

Concept ACK.

[hebasto]

Approach ACK 8019cf2.

@jonatack
Could you consider to replace s/ArgsManager::ALLOW_ANY/ArgsManager::ALLOW_BOOL/ for -getinfo command-line argument?

There is a general direction to move from the ArgsManager::ALLOW_ANY flag to more specific ones:

• 7414d38 (-rpcwhitelistdefault)
• refactor: Implement missing error checking for ArgsManager flags #16545

If you decide to implement this suggestion, the first commit and the last one could be combined.

[jonatack]

Thanks for reviewing, @hebasto! From what I can tell, it would be best to not change this (yet):

• ALLOW_BOOL appears to be unused in the codebase, apart from -rpcwhitelistdefault
• the change would have no effect on -getinfo command parsing behavior and tests
• in the event that we move to using more specific flags and that this one needs to be changed, many commands will need to be updated and ISTM it would be most coherent in terms of git history that they be changed together in the same commit or PR.

[hebasto]

Thanks for reviewing, @hebasto! From what I can tell, it would be best to not change this (yet):

• ALLOW_BOOL appears to be unused in the codebase, apart from -rpcwhitelistdefault

• the change would have no effect on -getinfo command parsing behavior and tests

• in the event that we move to using more specific flags and that this one needs to be changed, many commands will need to be updated and ISTM it would be most coherent in terms of git history that they be changed together in the same commit or PR.

FWIW, ArgsManager::ALLOW_BOOL is designed to use along with ArgsManager::GetBoolArg(). Additional error checking has not been implemented yet, unfortunately.

In any case, will continue my review :)

[hebasto]

Thanks for a separate commit that introduces the assert_scale() finction.

[jonatack]

Closing, will propose the changes one by one.