cli: display multiwallet total balance in -getinfo

[jonatack]

Per review suggestion in #18594 (comment), this PR adds a total_balance field for -getinfo in multiwallet mode.

  "balances": {
    "": 0.00001000,
    "Encrypted": 0.00003500,
    "day-to-day": 0.00000120,
    "side project": 0.00000094
  },
  "total_balance": 0.00003714
}

Updated help:

$ bitcoin-cli -h | grep -A3 getinfo
  -getinfo
       Get general information from the remote server, including the total
       balance and the balances of each loaded wallet when in
       multiwallet mode. Note that -getinfo is the combined result of
       several RPCs (getnetworkinfo, getblockchaininfo, getwalletinfo,
       getbalances, and in multiwallet mode, listwallets), each with
       potentially different state.

Credit to João Barbosa for the suggestion.

[promag]

Concept ACK.

Could update doc?

[jonatack]

Thanks @promag. Added a release note update.

[promag]

This is --help output

  -getinfo
       Get general information from the remote server. Note that unlike
       server-side RPC calls, the results of -getinfo is the result of
       multiple non-atomic requests. Some entries in the result may
       represent results from different states (e.g. wallet balance may
       be as of a different block from the chain state reported)

nit, I wonder if this should document the result.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• cli, test, doc: bitcoin-cli -getinfo multiwallet balances follow-ups #19089 (cli, test, doc: bitcoin-cli -getinfo multiwallet balances follow-ups by jonatack)
• cli/gui: support "@height" in place of blockhash for getblock on client side #16439 (cli/gui: support "@height" in place of blockhash for getblock on client side by ajtowns)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[jonatack]

I wonder it this should document the result.

Made an attempt at improving it.

[vahidjalaliii]

#19089

[luke-jr]

"balance" seems to perhaps oversimplify things...

Maybe "total_balance"?

[Wiphawee112]

ฉันจะทราบได้อย่างไร่่่่ะว่ายอดเงินอยุ่ทึ่ใหน ช่วยแนะนำด้วยค่ะ

[jonatack]

ฉันจะทราบได้อย่างไร่่่่ะว่ายอดเงินอยุ่ทึ่ใหน ช่วยแนะนำด้วยค่ะ

"I can know exactly what the balance is. Please help."

I'll take that as a Concept ACK :)

[jonatack]

"balance" seems to perhaps oversimplify things...

Maybe "total_balance"?

That was my initial thought as well. @promag WDYT?

[promag]

Also looks fine to me. I just mentioned balance to keep it backward compatible, but I guess that's not a concern in -cli.

[jonatack]

Thanks @luke-jr and @promag, updated to total_balance displayed after the balances and improved the test coverage.

[luke-jr]

Can we get these into the libbitcoin_util.a module? I think this is the third copy...

[jonatack]

Yes, third one. Agreed, a good follow-up.

[promag]

Why not in this PR or in a base PR especially considering there aren't ACKs.

[jonatack]

I think that refactoring would best be done in a separate PR.

[jonatack]

Closing, there are many open PRs and this has no ACKs. At least this PR was pulled into other Bitcoin implementations, so it will be useful for those users.