Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Send 'mempool' P2P command at the start of each P2P session #1918

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

jgarzik commented Oct 8, 2012

to query remote node mempool contents.

This supercedes pull #1833, which was fat-finger merged, and then resultant damage undone.

See #1833 for relevant comments on this pull request.

Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/6c4ef621c8e1b65454cc90a9d7877c81813e2263 for binaries and test log.

This could happen for one of several reasons:

  1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts
  2. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
  3. The test suite fails on either Linux i386 or Win32
  4. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)
Owner

sipa commented Oct 20, 2012

@jgarzik Any idea why BitcoinPullTester complains?

Send 'mempool' P2P command at the start of each P2P session
to query remote node mempool contents.
Contributor

jgarzik commented Nov 16, 2012

Closing, for now. Need to think more about @gmaxwell 's comments (see #1833, the previous version of this pull req) with regards to the proposed expiration of old, unconfirmed transactions in the memory pool.

@jgarzik jgarzik closed this Nov 16, 2012

Member

luke-jr commented Nov 25, 2012

Also note this broke Bitcoin-Qt builds. Looks like we need that startup time variable @Diapolo suggested a while back...

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jun 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment