remove 2 unneeded includes from util.cpp that are in the .h #1976

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants

Diapolo commented Nov 4, 2012

filesystem.hpp and thread.hpp are included in util.h, which is included in util.cpp

Owner

laanwj commented Nov 4, 2012

It's too bad all this stuff needs to be included in the headers

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/5b28f9261b93c03a833a4f693b1123192d9c349d for binaries and test log.

Owner

sipa commented Nov 5, 2012

Meh. Minimizing includes is nice, but specifying your direct dependencies is also nice, as it reduces problem when refactoring things...

Contributor

robbak commented Nov 5, 2012

Another point to remember- with other build systems, the order of includes
can change. In freebsd we have to patch one of the source files, because
the build system pulls in /usr/local/include/db4/db.h before is looks for
../db.h
Sometimes, duplicate includes are needed.
On 05/11/2012 10:45 AM, "Pieter Wuille" notifications@github.com wrote:

Meh. Minimizing includes is nice, but specifying your direct dependencies
is also nice, as it reduces problem when refactoring things...


Reply to this email directly or view it on GitHubhttps://github.com/bitcoin/bitcoin/pull/1976#issuecomment-10057955.

Diapolo commented Nov 5, 2012

@sipa My pulls are just an offer, if they don't make sense for all platforms we support, just comment and close them :).

Diapolo closed this Nov 10, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment