Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove -detachdb and stop's detach argument. #1978

Merged
merged 1 commit into from Nov 9, 2012

Conversation

Projects
None yet
4 participants
Owner

sipa commented Nov 4, 2012

As the only BDB database left is the wallet, and it is always detached.

This also removes the IsChainFile() predicate and related chainfile-specific logic.

@sipa sipa Remove -detachdb and stop's detach argument.
As the only BDB database left is the wallet, and it is always
detached.

Also remove IsChainFile() predicate and related chainfile-specific
logic.
9246707
Contributor

jgarzik commented Nov 4, 2012

ACK

Diapolo commented Nov 5, 2012

ACK, makes sense and should not need deeper discussions ;).

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/92467073adc11a76a26bbb55ccaed454169636f3 for binaries and test log.

@sipa sipa added a commit that referenced this pull request Nov 9, 2012

@sipa sipa Merge pull request #1978 from sipa/nodetach
Remove -detachdb and stop's detach argument.
b41de54

@sipa sipa merged commit b41de54 into bitcoin:master Nov 9, 2012

@laudney laudney pushed a commit to reddcoin-project/reddcoin that referenced this pull request Mar 19, 2014

@sipa sipa Merge pull request #1978 from sipa/nodetach
Remove -detachdb and stop's detach argument.
ee73711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment