Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

VariantClear@4 + shutdown@8 patch #1984

Merged
merged 1 commit into from Nov 15, 2012

Conversation

Projects
None yet
5 participants
Contributor

grimd34th commented Nov 5, 2012

merged 2 windows:LIBS lines so they happen when they need to (#976)
added -loleaut32 to fix VariantClear
moved -lws2_32 and others to existing windows:LIBS line

@grimd34th grimd34th VariantClear@4 + shutdown@8 patch
merged 2 windows:LIBS lines so they happen when they need to (#976)
added -loleaut32 to fix VariantClear
moved -lws2_32 and others to existing windows:LIBS line
90841fd

Diapolo commented Nov 5, 2012

@grimd34th I've been using a similar approach for months with my local Windows build, what wonders me is that the official build process seems to not need -loleaut32, any idea for this?

Otherwise I can confirm this change is needed to directly build on Windows!

Let's see what our pull-tester is making from this ;).

Owner

sipa commented Nov 5, 2012

ACK. Does not break gitian build.

Diapolo commented Nov 11, 2012

ACK then.

Contributor

grimd34th commented Nov 11, 2012

Diapolo, i had to add -loleaut32 as per https://github.com/Diapolo/bitcoin/commit/510f7fceb677ce1af3096f5c2b54f3832e5efee2 but i also shifted it around with the other deps

@laanwj laanwj added a commit that referenced this pull request Nov 15, 2012

@laanwj laanwj Merge pull request #1984 from grimd34th/patch-2
VariantClear@4 + shutdown@8 patch
6caffb5

@laanwj laanwj merged commit 6caffb5 into bitcoin:master Nov 15, 2012

Member

luke-jr commented Nov 16, 2012

@Diapolo Could you shed some light on whether 0.4.x - 0.6.x need this as well? Thanks

Diapolo commented Nov 16, 2012

I really can't comment for < 0.6 as I never compiled any versions below that for myself, but I remember that some Boost version update made me use a similar project-file. Dunno remember more details, sorry.

@laudney laudney pushed a commit to reddcoin-project/reddcoin that referenced this pull request Mar 19, 2014

@laanwj laanwj Merge pull request #1984 from grimd34th/patch-2
VariantClear@4 + shutdown@8 patch
1a9ca33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment